-
Notifications
You must be signed in to change notification settings - Fork 189
CellID.AllNeighbors: Allocate memory in one go #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The method AllNeighbors returns a maximum of 8 CellIDs, pre-allocates memory to avoid triggering expansion, and enhances performance.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Just a small style nit. Did you actually see this cause a performance issue on your end?
Note there are some failing checks. |
|
||
func BenchmarkAllNeighbors(b *testing.B) { | ||
level := 12 | ||
ll := LatLngFromDegrees(10.100001, 10.100002) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what these values buy over 10.1, 10.1 or 10.0, 10.0, but we can change it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what these values buy over 10.1, 10.1 or 10.0, 10.0, but we can change it later.
I think there is no difference.
Thanks! Did you just happen to notice this, or was it actually causing a performance problem? It would be great if you could look for other instances of the same problem. |
Pre-allocates memory to avoid triggering expansion, and enhances performance.