-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: use ELF and Mach-O binary notes #11048
Labels
Milestone
Comments
CL https://golang.org/cl/10709 mentions this issue. |
CL https://golang.org/cl/10707 mentions this issue. |
CL https://golang.org/cl/10706 mentions this issue. |
CL https://golang.org/cl/10708 mentions this issue. |
rsc
added a commit
that referenced
this issue
Jun 5, 2015
…as cmd/compile Other binary formats to follow. Using our own note instead of the GNU build ID note because we are not the GNU project, and I can't guarantee that the semantics of our note and the semantics of the GNU note will match forever. (Also they don't match today.) For #11048. Change-Id: Iec7e5a2e49d52b6d3a51b0aface2de7c77a45491 Reviewed-on: https://go-review.googlesource.com/10706 Reviewed-by: Ian Lance Taylor <iant@golang.org>
rsc
added a commit
that referenced
this issue
Jun 5, 2015
Other binary formats to follow. For #11048. Change-Id: Ia2d8b47c99c99d171c014b7cfd23c1c7ada5231c Reviewed-on: https://go-review.googlesource.com/10707 Reviewed-by: Ian Lance Taylor <iant@golang.org>
rsc
added a commit
that referenced
this issue
Jun 5, 2015
Non-ELF binary formats are much less flexible and typically do not have a good place to store the build ID. We store it as raw bytes at the beginning of the text segment. The only system I know of that will be upset about this is NaCl, and NaCl is an ELF system and does not use this. For #11048. Change-Id: Iaa7ace703c4cf36392e752eea9b55e2ce49e9826 Reviewed-on: https://go-review.googlesource.com/10708 Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
CL 9154 has a hack where it puts notes at the end of the executable file. Should use real binary notes.
The text was updated successfully, but these errors were encountered: