-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: submit queue, possibly implemented as optional auto-submit on +2 when trybots/slowbots with rebase pass #12482
Comments
Russ does not want automatic submission for his own CLs, but he's fine with it for others. We could add a new checkbox. |
/cc @adg |
yeah, adding a new checkbox for auto-submit is
fine too (actually I think we can make the 2nd
checkbox do both: invoke the trybot and submit
if it passes.)
|
Until we can have the trybots automatically rebase on the HEAD before running, I don't think this is wise. Am I being paranoid? |
On 4 September 2015 at 14:09, Andrew Gerrand notifications@github.com
|
On Thu, Sep 3, 2015 at 10:09 PM, Andrew Gerrand notifications@github.com
If we do want to implement, we need to make sure that the trybot will only |
See also: #9858 (rebase when testing) |
Here's a slightly more fleshed out suggestion, for discussion. Add an AutoSubmit score. When set to +1, it requests that GopherBot submit when the following conditions hold.
Once all those have been met, gopherbot does a trybot run after rebasing. If it passes, it submits. If it fails, then a human must intervene. |
I don't think that's necessary: presumably the reviewer can see the AutoSubmit score ahead of time, so if they want to explicitly “+2 with requested changes” they can revoke the AutoSubmit (perhaps by voting AutoSubmit -1?) at that point. If the uploader of the CL does not have submit permission, then uploading a new snapshot should also revoke the AutoSubmit +1. |
This condition seems a bit too strong: a -1 or -2 on the current patchset should certainly cancel auto-submit, but if someone votes -1 or -2 and the CL is subsequently reworked (and those negative votes removed), then it should not be necessary to clear and re-set the AutoSubmit +1 in order for it to take effect. |
That is true, but I'd rather the default be safe.
Again, that is true, but I'd rather be conservative, at least to start. These minor disagreements notwithstanding, I'd be happy with just about any variant of this. |
/cc @FiloSottile who also wanted this. |
Yup, and I also expected it to be an AutoSubmit vote. I'd like to send simple CLs by |
I would love a submit queue. Ideally we could run all the trybots (including slowbots) when we actually submit a CL. (And if we're more like a submit queue and do a rebase when submitting, the results can be copied straight to build.golang.org when the tests pass and the CL is submitted). Personally I'd prefer to not have autosubmit but instead have the submit button trigger a test run, submitting if the tests pass, but i'd be pretty happy with autosubmit too. |
CC @rolandshoemaker. |
I see a trend of giving +2 together with trybot recently.
because we've defined that +2 means it's ok to submit,
I wonder if trybot could just submit the change (on behave
of the user who gives +2 and also invokes the trybot) if
the trybot runs are successful.
what do you think?
The text was updated successfully, but these errors were encountered: