New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: optional auto-submit on +2 when trybots (with rebase) pass #12482

Open
minux opened this Issue Sep 3, 2015 · 7 comments

Comments

Projects
None yet
5 participants
@minux
Member

minux commented Sep 3, 2015

I see a trend of giving +2 together with trybot recently.
because we've defined that +2 means it's ok to submit,
I wonder if trybot could just submit the change (on behave
of the user who gives +2 and also invokes the trybot) if
the trybot runs are successful.

what do you think?

@bradfitz

This comment has been minimized.

Member

bradfitz commented Sep 3, 2015

Russ does not want automatic submission for his own CLs, but he's fine with it for others.

We could add a new checkbox.

@bradfitz bradfitz added the Builders label Sep 3, 2015

@bradfitz

This comment has been minimized.

Member

bradfitz commented Sep 3, 2015

/cc @adg

@minux

This comment has been minimized.

Member

minux commented Sep 3, 2015

@adg

This comment has been minimized.

Contributor

adg commented Sep 4, 2015

Until we can have the trybots automatically rebase on the HEAD before running, I don't think this is wise. Am I being paranoid?

@mwhudson

This comment has been minimized.

Contributor

mwhudson commented Sep 4, 2015

On 4 September 2015 at 14:09, Andrew Gerrand notifications@github.com
wrote:

Until we can have the trybots automatically rebase on the HEAD before
running, I don't think this is wise. Am I being paranoid?

I don't think so.

@minux

This comment has been minimized.

Member

minux commented Sep 4, 2015

On Thu, Sep 3, 2015 at 10:09 PM, Andrew Gerrand notifications@github.com
wrote:

Until we can have the trybots automatically rebase on the HEAD before
running, I don't think this is wise. Am I being paranoid?

If that could cause problems, then it will also affect us now because there
is no
way for a human reviewer to notice anything unusual before clicking the
submit
button. The trybot could do a few more checks before submission though.

If we do want to implement, we need to make sure that the trybot will only
try to
submit the revision that the trybot has been run on.

@rsc rsc added this to the Unreleased milestone Oct 23, 2015

@bradfitz bradfitz self-assigned this May 12, 2017

@bradfitz bradfitz changed the title from gerrit: automatic submission if trybot passes and +2 given? to x/build: optional auto-submit on +2 when trybots (with rebase) pass May 12, 2017

@bradfitz

This comment has been minimized.

Member

bradfitz commented May 12, 2017

See also: #9858 (rebase when testing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment