x/build: submit queue, possibly implemented as optional auto-submit on +2 when trybots/slowbots with rebase pass

[minux]

I see a trend of giving +2 together with trybot recently.
because we've defined that +2 means it's ok to submit,
I wonder if trybot could just submit the change (on behave
of the user who gives +2 and also invokes the trybot) if
the trybot runs are successful.

what do you think?

[bradfitz]

Russ does not want automatic submission for his own CLs, but he's fine with it for others.

We could add a new checkbox.

[bradfitz]

/cc @adg

[minux]

yeah, adding a new checkbox for auto-submit is fine too (actually I think we can make the 2nd checkbox do both: invoke the trybot and submit if it passes.)

[adg]

Until we can have the trybots automatically rebase on the HEAD before running, I don't think this is wise. Am I being paranoid?

[mwhudson]

On 4 September 2015 at 14:09, Andrew Gerrand notifications@github.com
wrote:

Until we can have the trybots automatically rebase on the HEAD before
running, I don't think this is wise. Am I being paranoid?

I don't think so.

[minux]

On Thu, Sep 3, 2015 at 10:09 PM, Andrew Gerrand notifications@github.com
wrote:

Until we can have the trybots automatically rebase on the HEAD before
running, I don't think this is wise. Am I being paranoid?

If that could cause problems, then it will also affect us now because there
is no
way for a human reviewer to notice anything unusual before clicking the
submit
button. The trybot could do a few more checks before submission though.

If we do want to implement, we need to make sure that the trybot will only
try to
submit the revision that the trybot has been run on.

[bradfitz]

See also: #9858 (rebase when testing)