sort: possibility for deduplication

[stemar94]

Hi I'm missing the possibility for sorting+dedup via std lib.
So I implemented a function DedupSorted(data Interface) (n int) for the sort package.
It rearranges different elements of data to the front of the Interface
preserving order and returns the number of different elements.

So for example if I want to sort+dedup a slice of strings:

strings :=[]string{"c", "a", "b", "a", "b"}
sort.Strings(strings)
n:=sort.DedupSorted(sort.StringSlice(strings))
strings=strings[:n]
fmt.Println(strings)

would give me

[a b c]

If there is already something like this I would be happy to know and I'm sorry for filing this issue.
Comments are welcome.

Marvin

[gopherbot]

CL https://golang.org/cl/15016 mentions this issue.

[minux]

A general advice: when you file an API addition issue, before sending CL for review, please at least wait for some consensus on the issue tracker. As Burcu mentioned in the code review, I don't think this functions belongs to the sort package. If we have a sortutil package, perhaps.

[cznic]

If we have a sortutil package, perhaps.

sortutil.Dedupe ;-)

[rakyll]

Generally, it is better to propose new APIs on golang-dev mailing list first where more contributors are actively watching each discussion. We need to discuss this function's value with other contributors to reason why it should or should not be merged into the standard library and where it would fit.

[adg]

Generally, it is better to propose new APIs on golang-dev mailing list first where more contributors are actively watching each discussion.

Actually the correct place to propose new API additions and other changes is through the issue tracker.

https://golang.org/s/proposal-process

[davecheney]

I don't think this needs to live in the standard library, here is an
example of the functionality you want

http://godoc.org/github.com/xtgo/set#Uniq

On Mon, Sep 28, 2015 at 12:44 PM, Andrew Gerrand notifications@github.com
wrote:

Generally, it is better to propose new APIs on golang-dev mailing list
first where more contributors are actively watching each discussion.

Actually the correct place to propose new API additions and other changes
is through the issue tracker.

https://golang.org/s/proposal-process

—
Reply to this email directly or view it on GitHub
#12763 (comment).