Join GitHub today
cmd/compile: many tests on s390x fail when -covermode=atomic is used #24449
What version of Go are you using (
Here is a small testcase:
I extracted a scanner module from our spdx parser. Its a bit of a random example but it is pretty small. I also simplified the testcase to use no external libs (it used to use gocheck.v1) and only a single trivial test input.
When I run it on a s390x:
What is interessting is that if I add a debug line into the scanner.go code like this:
The last line looks suspicious -
I also added the debug enabled script.
But this is just one instance of the failure, we see many more so it seems like something fundamental is wrong with coverage=atomic.
Thanks for the super quick fix. I can confirm the fix works:
…flags on s390x The atomic add instructions modify the condition code and so need to be marked as clobbering flags. Fixes #24449. Change-Id: Ic69c8d775fbdbfb2a56c5e0cfca7a49c0d7f6897 Reviewed-on: https://go-review.googlesource.com/101455 Run-TryBot: Michael Munday <firstname.lastname@example.org> TryBot-Result: Gobot Gobot <email@example.com> Reviewed-by: Brad Fitzpatrick <firstname.lastname@example.org> Reviewed-on: https://go-review.googlesource.com/102788 Run-TryBot: Andrew Bonventre <email@example.com> Reviewed-by: Michael Munday <firstname.lastname@example.org>