Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/compile: many tests on s390x fail when -covermode=atomic is used #24449
What version of Go are you using (
changed the title
Many tests on go1.10/s390x fail when `-covermode="atomic"` is used
Mar 19, 2018
Here is a small testcase:
I extracted a scanner module from our spdx parser. Its a bit of a random example but it is pretty small. I also simplified the testcase to use no external libs (it used to use gocheck.v1) and only a single trivial test input.
When I run it on a s390x:
What is interessting is that if I add a debug line into the scanner.go code like this:
The last line looks suspicious -
I also added the debug enabled script.
But this is just one instance of the failure, we see many more so it seems like something fundamental is wrong with coverage=atomic.
Thanks for the super quick fix. I can confirm the fix works: