Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/gerritbot: perform gofmt checks before pushing to Gerrit #24946
In https://golang.org/cl/99337 a file using CRLF instead of LF line endings was added. When using git-codereview to send CLs, there is a gofmt check which prevents this. But it seems there is no corresponding check when sending CLs via Github PRs.
It would be nice to run the gofmt check also for PRs submitted via Github.
CL 110555 introduced some changes which were not properly gofmt'ed. Because the CL was sent via Github the gofmt checks usually performed by git-codereview didn't catch this (see #24946). Change-Id: I65c1271620690dbeec88b4ce482d158f7d6df45d Reviewed-on: https://go-review.googlesource.com/114255 Run-TryBot: Tobias Klauser <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Alex Brainman <email@example.com>
CL 109361 introduced some changes which were not properly gofmt'ed. Because the CL was sent via Github no gofmt checks were performed on it (cf. #24946, #18548). Change-Id: I207065f01161044c420e272f4fd112e0a59be259 Reviewed-on: https://go-review.googlesource.com/115356 Run-TryBot: Tobias Klauser <firstname.lastname@example.org> Reviewed-by: Brad Fitzpatrick <email@example.com>