Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: perform gofmt checks before pushing to Gerrit #24946

Open
tklauser opened this issue Apr 19, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@tklauser
Copy link
Member

commented Apr 19, 2018

In https://golang.org/cl/99337 a file using CRLF instead of LF line endings was added. When using git-codereview to send CLs, there is a gofmt check which prevents this. But it seems there is no corresponding check when sending CLs via Github PRs.

It would be nice to run the gofmt check also for PRs submitted via Github.

/cc @bradfitz @andybons

@gopherbot gopherbot added this to the Unreleased milestone Apr 19, 2018

@gopherbot gopherbot added the Builders label Apr 19, 2018

@gopherbot

This comment has been minimized.

Copy link

commented May 23, 2018

Change https://golang.org/cl/114255 mentions this issue: debug/pe: gofmt

@tklauser

This comment has been minimized.

Copy link
Member Author

commented May 23, 2018

There was a similar issue with https://golang.org/cl/110555

gopherbot pushed a commit that referenced this issue May 23, 2018

debug/pe: gofmt
CL 110555 introduced some changes which were not properly gofmt'ed.
Because the CL was sent via Github the gofmt checks usually performed by
git-codereview didn't catch this (see #24946).

Change-Id: I65c1271620690dbeec88b4ce482d158f7d6df45d
Reviewed-on: https://go-review.googlesource.com/114255
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>

@andybons andybons changed the title x/build/cmd/gopherbot: perform gofmt checks before pushing to Gerrit x/build/cmd/gerritbot: perform gofmt checks before pushing to Gerrit May 23, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

commented May 23, 2018

I still would rather prioritize #18548

@gopherbot

This comment has been minimized.

Copy link

commented May 30, 2018

Change https://golang.org/cl/115356 mentions this issue: os/exec: gofmt

gopherbot pushed a commit that referenced this issue May 30, 2018

os/exec: gofmt
CL 109361 introduced some changes which were not properly gofmt'ed.
Because the CL was sent via Github no gofmt checks were performed
on it (cf. #24946, #18548).

Change-Id: I207065f01161044c420e272f4fd112e0a59be259
Reviewed-on: https://go-review.googlesource.com/115356
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.