New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: GetCertificate called on resumed sessions #25352

Open
FiloSottile opened this Issue May 11, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@FiloSottile
Member

FiloSottile commented May 11, 2018

GetCertificate is called just before checking the client session ticket. If the ticket is valid and the session is resumed, that call is probably pointless.

Off the top of my head, I can't remember why the server would need to know its own certificate in a resumed session, but there might be something I'm forgetting around renegotiation. Look into it, and if possible move the GetCertificate call after checkForResumption.

@FiloSottile FiloSottile added this to the Go1.12 milestone May 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment