cmd/go: legacy dependency conversion bypasses GOPROXY #33767
Well, one of my friends (@EDDYCJY) tried to migrate a project from their company from golang/dep to Go modules. When he executes
I investigated it as much as I can. Then I think the "inappropriate" that @rsc said before may have gone now, since
I just submitted a patch. If the patch can be merged, then I suggest applying those changes to Go 1.13 since it has not yet been released.
changed the title
cmd/go: add module proxy support for `modfetch.ImportRepoRev`
Aug 22, 2019
Go 1.13 is well into the release freeze at this point, so we're pretty much only fixing critical regressions from here on out. The good news is, the tree will be opening for 1.14 very soon.
Hi @bcmills, someone has reported this bug to me (again) today. This bug isn't only triggered when
So, please merge https://golang.org/cl/191218 and consider applying those changes to Go 1.13.1 (or 1.13.2). We really need it.
CL 191218 is in, although I don't think it meets the backport criteria (it wasn't a regression and the workaround is to run
Regarding other operations that might generate a
The reason for the test failure seems to be that some of the converted formats specify package paths rather than module paths, and
The usual function that converts a package path to a module path is
The circular dependency exists because
Role (2) will need significant refactoring for #26904 anyway, so I'm planning to revisit this once that has been addressed.