Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link/internal/ld: TestRuntimeTypeAttrInternal flaky on Windows #34774

Open
bcmills opened this issue Oct 8, 2019 · 5 comments
Open

cmd/link/internal/ld: TestRuntimeTypeAttrInternal flaky on Windows #34774

bcmills opened this issue Oct 8, 2019 · 5 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 8, 2019

Seen on the windows-amd64-2016 builder in https://storage.googleapis.com/go-build-log/4a655811/windows-amd64-2016_5d978c1a.log:

--- FAIL: TestRuntimeTypeAttrInternal (0.73s)
    dwarf_test.go:973: could not run test program: fork/exec C:\Users\gopher\AppData\Local\Temp\1\TestRuntimeType696325427\out.exe: This version of %1 is not compatible with the version of Windows you're running. Check your computer's system information and then contact the software publisher.
FAIL
FAIL	cmd/link/internal/ld	3.767s

CC @cherrymui @jeremyfaller

@bcmills bcmills added this to the Go1.14 milestone Oct 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@bcmills bcmills changed the title cmd/link/internal/ld: TestRuntimeTypeAttrInternal flake on windows-amd64-2016 builder cmd/link/internal/ld: TestRuntimeTypeAttrInternal flaky on Windows Nov 21, 2019
@bcmills bcmills added the OS-Windows label Nov 21, 2019
@jeremyfaller
Copy link
Contributor

@jeremyfaller jeremyfaller commented Nov 21, 2019

Is this a flaky, or repeated? Judging from it's infrequency occurrence, it looks a flaky??

I can't see any new reason for this test to fail.

@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 26, 2019

Yes, it appears to be a flake, but it's happened enough times that it seems unlikely to be a hardware issue (cosmic ray or thermal jitter).

It's not obvious to me whether it's a bug in the test, a bug cmd/go, a bug in os/exec, or a bug in Windows.

@bcmills
Copy link
Member Author

@bcmills bcmills commented Nov 26, 2019

@alexbrainman
Copy link
Member

@alexbrainman alexbrainman commented Dec 21, 2019

Looking at testRuntimeTypeAttr source, I notice that you open file

f := gobuild(t, dir, prog, flags)

and then execute the file

... exec.Command(f.path).CombinedOutput()

I am surprised that Windows allows you to execute opened file.

Perhaps unrelated, but I also noticed that file f is never closed. Why?

Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.