Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: apparent test deadlock on linux-ppc64-buildlet #35188

Closed
bcmills opened this issue Oct 26, 2019 · 3 comments
Closed

runtime: apparent test deadlock on linux-ppc64-buildlet #35188

bcmills opened this issue Oct 26, 2019 · 3 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Oct 26, 2019

From linux-ppc64-buildlet (https://build.golang.org/log/620feae79d01758bdc246133f337e735aa269837), a timeout with lots of blocked tests and the running goroutine obscured:

[…]
goroutine 2 [running]:
	goroutine running on other thread; stack unavailable
created by runtime.init.4
	/tmp/workdir-host-linux-ppc64-osu/go/src/runtime/proc.go:242 +0x34
[…]
*** Test killed with quit: ran too long (6m0s).
FAIL	runtime	360.006s

CC @aclements @mknyszek @laboger

@bcmills bcmills added this to the Go1.14 milestone Oct 26, 2019
@bcmills bcmills changed the title runtime: test timeout on linux-ppc64-buildlet runtime: apparent test deadlock on linux-ppc64-buildlet Oct 26, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Oct 28, 2019

Change https://golang.org/cl/203886 mentions this issue: env/linux-ppc64/osuosl: add Docker setup notes

gopherbot pushed a commit to golang/build that referenced this issue Nov 4, 2019
Collaboration with @tiborvass at Docker who got Docker running on
big-endian PPC64. Go for ppc64 doesn't support cgo or external
linking, so runc doesn't work, but a new OCI-compliant runc
implementation written in C (https://github.com/containers/crun) means
we can run Docker after all. See NOTES & build-*.sh

Then add a Dockerfile & associated cleanup in buildlet & stage0 to use
rundockerbuildlet.

Once done, might help with golang/go#35188, golang/go#32613, etc.

Fixes golang/go#34830
Updates golang/go#21260

Change-Id: I43d7afa1d58bbdfa16e3c57670bc41f1d1932d80
Reviewed-on: https://go-review.googlesource.com/c/build/+/203886
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
codebien added a commit to codebien/build that referenced this issue Nov 13, 2019
Collaboration with @tiborvass at Docker who got Docker running on
big-endian PPC64. Go for ppc64 doesn't support cgo or external
linking, so runc doesn't work, but a new OCI-compliant runc
implementation written in C (https://github.com/containers/crun) means
we can run Docker after all. See NOTES & build-*.sh

Then add a Dockerfile & associated cleanup in buildlet & stage0 to use
rundockerbuildlet.

Once done, might help with golang/go#35188, golang/go#32613, etc.

Fixes golang/go#34830
Updates golang/go#21260

Change-Id: I43d7afa1d58bbdfa16e3c57670bc41f1d1932d80
Reviewed-on: https://go-review.googlesource.com/c/build/+/203886
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@ceseo
Copy link
Contributor

@ceseo ceseo commented Nov 25, 2019

I don't see the deadlocks for a while. Looks like it's gone.

@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Nov 25, 2019

Thanks, closing. We've fixed several potentially deadlock causing bugs in the last few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.