Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: unify list, configuration of repos, simplifying add new ones #36047

Closed
bradfitz opened this issue Dec 9, 2019 · 7 comments
Closed

x/build: unify list, configuration of repos, simplifying add new ones #36047

bradfitz opened this issue Dec 9, 2019 · 7 comments
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Dec 9, 2019

https://github.com/golang/go/wiki/CreatingSubRepository is super complicated.

We had our list of Go repos is a half dozen places.

https://golang.org/cl/208697 added a new repos package for use in x/build and uses it in a number of places.

https://golang.org/cl/210461 fleshes it out more and uses it for maintnerd, removing another list.

Remaining:

  • gerritbot.go's
// Gerrit projects we accept PRs for.                                                                                                                                                                      
var gerritProjectWhitelist = map[string]bool{
        "arch":           true,
        "benchmarks":     true,
        "blog":           true,
        "build":          true,
        "crypto":         true,
        "debug":          true,
        "dl":             true,
        "example":        true,
...
  • simplify the CreatingSubRepository wiki page.
@gopherbot gopherbot added this to the Unreleased milestone Dec 9, 2019
@gopherbot gopherbot added the Builders label Dec 9, 2019
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 9, 2019

Change https://golang.org/cl/210461 mentions this issue: repos: flesh out package more, use it in maintnerd

@toothrot toothrot added the NeedsFix label Dec 9, 2019
gopherbot pushed a commit to golang/build that referenced this issue Dec 10, 2019
This removes yet another list of all our repos.

(Goal is to simplify https://github.com/golang/go/wiki/CreatingSubRepository)

Most of the work was in earlier CL 208697.

Updates golang/go#36047

Change-Id: I9147b959fe6574e2f809091d08d360051b69402e
Reviewed-on: https://go-review.googlesource.com/c/build/+/210461
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 10, 2019

Change https://golang.org/cl/210741 mentions this issue: cmd/gerrit: use the new repos package for repo policy

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 10, 2019

Change https://golang.org/cl/210744 mentions this issue: cmd/golangorg: remove duplicate list of repo names from the /x/ handler

gopherbot pushed a commit to golang/build that referenced this issue Dec 10, 2019
The only behavior change is that "gofrontend" is now included, which
is arguably a bug fix (an example of our various lists of repos
getting out of sync). At least, I don't recall any discussion of
omitting that repo. Ian +1'd this CL, so keeping them on.

If we want to exclude a repo from gerritbot in the future we'll need
to add some policy fields/methods to the repos package.

Updates golang/go#36047

Change-Id: I877cd3b6c292ac888863523e05799208e247499f
Reviewed-on: https://go-review.googlesource.com/c/build/+/210741
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 13, 2019

Change https://golang.org/cl/211318 mentions this issue: repos: add descriptions from golang.org/pkg/#subrepo

gopherbot pushed a commit to golang/build that referenced this issue Dec 13, 2019
Updates golang/go#36047

Change-Id: I94ce5537cfd37d211f24a911bd983af436c25009
Reviewed-on: https://go-review.googlesource.com/c/build/+/211318
Reviewed-by: Bryan C. Mills <bcmills@google.com>
gopherbot pushed a commit to golang/website that referenced this issue Dec 13, 2019
Also, add tests.

This also removes the golang.org/x/codereview redirect because
code.google.com and our Mercurial repository are long dead.

Updates golang/go#36047

Change-Id: I0aacbe5a963b0edeea2dd2f1b2e2ad6a2f1f7319
Reviewed-on: https://go-review.googlesource.com/c/website/+/210744
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Dec 13, 2019

Updated the wiki. I think this is done. If people find more lists of repos we can reopen this.

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Dec 13, 2019

If people find more lists

I found two more, but I don't think they're worth implementing right now, because it's a lot of forced changes and not a lot of benefit. I've opened issue #36136 to track them so that it can be considered after more progress is made on #29206 and it becomes a lot easier to implement.

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 2, 2020

Change https://golang.org/cl/221821 mentions this issue: repos: change protobuf import path to google.golang.org/protobuf

gopherbot pushed a commit to golang/build that referenced this issue Mar 2, 2020
The import path of the https://go.googlesource.com/protobuf repository
is google.golang.org/protobuf, as can be seen by looking at its go.mod
file at https://go.googlesource.com/protobuf/+/refs/tags/v1.20.0/go.mod#1.

https://github.com/google/protobuf is the C++ protobuf repository.

It was unintentionally changed to an invalid import path during the
refactor in CL 208697 and CL 210461, likely due to a mix-up with a
similar-looking import path github.com/golang/protobuf used for
protobuf API v1. See https://go.googlesource.com/protobuf/#historical-legacy.

Updates golang/go#36047

Change-Id: I03046f33cda3d0c5efa7a2a6059a1cf5c71d6c34
Reviewed-on: https://go-review.googlesource.com/c/build/+/221821
Reviewed-by: Damien Neil <dneil@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.