Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: expose internal/trace package available as non internal package #38971

Open
povilasv opened this issue May 9, 2020 · 3 comments
Open

proposal: expose internal/trace package available as non internal package #38971

povilasv opened this issue May 9, 2020 · 3 comments
Labels
Projects
Milestone

Comments

@povilasv
Copy link
Contributor

@povilasv povilasv commented May 9, 2020

This is a feature request, not a bug.

I'm helping to build conprof, which is a continuous profiling application similiar to Google Wide Profiling. We would like to add support for Go's trace profiles (typically /debug/pprof/trace endpoint).

In order to do that we would need to have internal/trace package to be exposed.

Related conprof issue: conprof/conprof#46

@odeke-em odeke-em changed the title Make internal/trace package available as non internal package proposal: expose internal/trace package available as non internal package May 9, 2020
@gopherbot gopherbot added this to the Proposal milestone May 9, 2020
@gopherbot gopherbot added the Proposal label May 9, 2020
@rsc
Copy link
Contributor

@rsc rsc commented Jun 10, 2020

internal/trace and the trace format itself almost certainly need to be rewritten to make it easier to load only a subset of the file. The current format basically requires loading the entire file to do anything useful, and that fails for large traces.

We should definitely not expose internal/trace in its current form. It's fine to copy if you need something soon.

@rsc rsc added this to Incoming in Proposals Jun 10, 2020
@povilasv
Copy link
Contributor Author

@povilasv povilasv commented Jun 11, 2020

Thanks for the answer. Is there an issue for rewrite and what needs to happen? Would like to take a look at it, maybe I can help.

@rsc
Copy link
Contributor

@rsc rsc commented Jun 24, 2020

There isn't active work on that. I'd say just copy the package (as the license permits) and modify to suit your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Proposals
Incoming
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.