Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/internal/stack: hyphenated identifiers not supported #39762
Does this issue reproduce with the latest release?
Yes (verified by looking at the source code)
What did you do?
Run the stack tool on a dump file created when a Go process got a SIGABRT.
What did you expect to see?
A single summary to be printed for all the goroutine stack traces.
What did you see instead?
Multiple summaries were displayed. This makes it hard to determine, for example, the callstack that is most common in the dump file.
The reason is that the "package" and "function" parts of the regexp in "reCall" in https://github.com/golang/tools/blob/master/internal/stack/parse.go do not include a hyphen. However, the compiler can use hyphens for internally generated function names as discussed in https://stackoverflow.com/questions/32925344/why-is-there-a-fm-suffix-when-getting-a-functions-name-in-go.