net: ParseIP return 16 bytes length IP for IPv4 address

[baislsl]

net.ParseIP parse the IPv4 address into 4 bytes length IP result, but converts it into a 16 bytes length redundantly.

Below is the relative code in net/ip.go

func ParseIP(s string) IP {
	for i := 0; i < len(s); i++ {
		switch s[i] {
		case '.':
			return parseIPv4(s)
		case ':':
			return parseIPv6(s)
		}
	}
	return nil
}

// Parse IPv4 address (d.d.d.d).
func parseIPv4(s string) IP {
	var p [IPv4len]byte
	for i := 0; i < IPv4len; i++ {
		if len(s) == 0 {
			// Missing octets.
			return nil
		}
		if i > 0 {
			if s[0] != '.' {
				return nil
			}
			s = s[1:]
		}
		n, c, ok := dtoi(s)
		if !ok || n > 0xFF {
			return nil
		}
		s = s[c:]
		p[i] = byte(n)
	}
	if len(s) != 0 {
		return nil
	}
	return IPv4(p[0], p[1], p[2], p[3]) // seems to be unnecessary?
}

func IPv4(a, b, c, d byte) IP {
	p := make(IP, IPv6len)
	copy(p, v4InV6Prefix)
	p[12] = a
	p[13] = b
	p[14] = c
	p[15] = d
	return p
}

Suppose we can return p directly without transfer in parseIPv4 ?

[toothrot]

I think this is a duplicate of #18804, let me know if you agree.

[toothrot]

/cc @bradfitz @ianlancetaylor

[baislsl]

I think this is a duplicate of #18804, let me know if you agree.

It does. Discussion in #18804 more comprehensive.