Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: combine phielim and copyelim into a single pass? #40610

Open
surechen opened this issue Aug 6, 2020 · 3 comments
Open

cmd/compile: combine phielim and copyelim into a single pass? #40610

surechen opened this issue Aug 6, 2020 · 3 comments
Milestone

Comments

@surechen
Copy link
Contributor

@surechen surechen commented Aug 6, 2020

What version of Go are you using (go version)?

$ go version
go version go1.14.3 windows/amd64

Does this issue reproduce with the latest release?

yes

What did you do?

I find a todo tag in line 419 of the file cmd/compile/internal/ssa/compile.go. It seems that the previous developer was considering combing phielim and copyelim. Whether there's still interest in this? In fact I am reading the compiler source code recently and interested in this. Can I try to do this work. Could you give me some advices about what I should pay attention to?

@randall77
Copy link
Contributor

@randall77 randall77 commented Aug 6, 2020

There's interest if it actually helps, which might be the case or it might not. "Helps" here means it makes the compiler faster.

You can check compiler phase timings by giving flags like -d="ssa/early copyelim/time" to the compiler (more examples described in compile.go:PhaseOption).

@surechen
Copy link
Contributor Author

@surechen surechen commented Aug 7, 2020

-d="ssa/early copyelim/time"

Ok, thank you very much. I'll give it a try.

@toothrot toothrot added this to the Backlog milestone Aug 7, 2020
@josharian
Copy link
Contributor

@josharian josharian commented Aug 8, 2020

You might also find github.com/josharian/compilecmp handy for testing compiler performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.