Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: completion insertion is overwriting suffix #40871

Open
muirdm opened this issue Aug 18, 2020 · 0 comments
Open

x/tools/gopls: completion insertion is overwriting suffix #40871

muirdm opened this issue Aug 18, 2020 · 0 comments
Labels

Comments

@muirdm
Copy link

@muirdm muirdm commented Aug 18, 2020

Currently gopls is overwriting the surrounding suffix (in addition to prefix) when inserting candidates:

// completing to "food" currently results in "food" instead of "foodoo"
f<>oo

I think it's from https://go-review.googlesource.com/c/tools/+/208501 changing the surrounding's range from [ident.Pos(), c.pos] to [ident.Pos(), ident.End()].

/cc @heschik

@gopherbot gopherbot added this to the Unreleased milestone Aug 18, 2020
@stamblerre stamblerre added this to To Do in gopls/v1.0.0 Aug 26, 2020
@stamblerre stamblerre removed this from Bugs in gopls/v1.0.0 Sep 9, 2020
@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.