Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: remove protocol from source code links #26

Closed
wants to merge 1 commit into from
Closed

x/pkgsite: remove protocol from source code links #26

wants to merge 1 commit into from

Conversation

Stexxe
Copy link
Contributor

@Stexxe Stexxe commented Apr 14, 2021

A new template function for stripping scheme from URL applied to repository
URL in the Details block.

Fixes golang/go#40943

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Apr 14, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 5d5902d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/pkgsite/+/310229 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/310229.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/310229.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/310229.
After addressing review feedback, remember to publish your drafts!

A new template function for stripping scheme from URL applied to repository
URL in the Details block.

Fixes golang/go#40943
@gopherbot
Copy link
Contributor

This PR (HEAD: a2b0ca2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/pkgsite/+/310229 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Aleksei Tirman:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/310229.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jamal Carvalho:

Patch Set 2: Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/310229.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 19, 2021
A new template function for stripping scheme from URL applied to repository
URL in the Details block.

Fixes golang/go#40943

Change-Id: Ie767e90c3763e8792544b5df62ce79a5cf00374f
GitHub-Last-Rev: a2b0ca2
GitHub-Pull-Request: #26
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/310229
Trust: Jamal Carvalho <jamal@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/310229 has been merged.

@gopherbot gopherbot closed this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/pkgsite: trim https:// from source links
2 participants