Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: support searching by <package>.<identifier> #44142

Open
matttproud opened this issue Feb 7, 2021 · 1 comment
Open

x/pkgsite: support searching by <package>.<identifier> #44142

matttproud opened this issue Feb 7, 2021 · 1 comment

Comments

@matttproud
Copy link
Contributor

@matttproud matttproud commented Feb 7, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/search?q=sql.DB

What is your user agent?

Mozilla/5.0 (X11; CrOS x86_64 13597.66.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.109 Safari/537.36

Screenshot

Screenshot 2021-02-07 13 52 26

What did you do?

I wanted to view the documentation for sql.DB, which is part of the standard distribution. I entered the search query of sql.DB into the interface, and it gave me no good results.

What did you expect to see?

Basically this but on the new web site: https://golang.org/pkg/database/sql/#DB

What did you see instead?

I don't know how the web application is implemented, but I expect either standard distribution packages are not indexed, the search query format "<package name>.<Identifier>" is not supported, or the result ranking is somehow deficient. I had been using this on old Godoc with great success since time immemorial.

@gopherbot gopherbot added the pkgsite label Feb 7, 2021
@gopherbot gopherbot added this to the Unreleased milestone Feb 7, 2021
@julieqiu julieqiu changed the title x/pkgsite: search by <package>.<identifier> no longer possible x/pkgsite: support searching by <package>.<identifier> Feb 9, 2021
@magical
Copy link
Contributor

@magical magical commented Feb 20, 2021

I'd go further and allow searching for just <identifier>, at least within the standard library. I occasionally use golang.org's search to find, e.g., a function that i can't remember the package for https://golang.org/search?q=WriteFile#Functions, or all the types that implement some method https://golang.org/search?q=Sum#Global.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants