Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text/internal/language: Script overflows during generation #45093

Open
rolandshoemaker opened this issue Mar 17, 2021 · 1 comment
Open

x/text/internal/language: Script overflows during generation #45093

rolandshoemaker opened this issue Mar 17, 2021 · 1 comment
Labels
NeedsInvestigation
Milestone

Comments

@rolandshoemaker
Copy link
Member

@rolandshoemaker rolandshoemaker commented Mar 17, 2021

The IANA Language Subtag Registry contains more than 256 scripts, causing the generated script indices to overflow the Script type. Bumping it to uint16 seems reasonable.

cc @mpvl

@gopherbot gopherbot added this to the Unreleased milestone Mar 17, 2021
@cherrymui cherrymui added the NeedsInvestigation label Mar 18, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 23, 2021

Change https://golang.org/cl/304029 mentions this issue: internal/language: bump script types to uint16 and update registry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

3 participants