x/text: tag new release

[tpotjj]

What version of Go are you using?

$ go version 1.18

Does this issue reproduce with the latest release?

yes

Does this issue reproduce with go 1.17.8?

no

What operating system and processor architecture are you using (go env)?

go env Output

GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/joris/go/bin"
GOCACHE="/home/joris/.cache/go-build"
GOENV="/home/joris/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/joris/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/joris/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.17.8"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build4031452016=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I was trying to create translations for my Go (fiber) project, at first I thought this was an issue related to Fiber.
So I created a new empty project, started all over (without Fiber), and got the same error.

The tutorial I was following: https://www.alexedwards.net/blog/i18n-managing-translations

Then I realised that I've updated Go last week, so I downgraded my Go version to 1.17, and everything worked again.
What I saw when I my Go version was at 1.18:

panic: in crypto/sha256.Sum224: cannot convert slice t0[:] ([]byte) to *[28]byte

How to reproduce?

This is the repo for my project: https://github.com/Joris1Jansen/SimpleNotesApi/tree/GOLANG-ISSUE_WITH_GOTEXT
Please, don't look at the complete mess of my code, this is a project I'm trying out all new things I want to learn.

The current version in go.mod is 1.17, so everything should work now.

go generate ./locale/locale.go

Should return something like:

de-DE: Missing entry for "Welcome!".                                                                                                  
fr-CH: Missing entry for "Welcome!". 

BUT, if we upgrade to go version 1.18

go generate ./locale/locale.go

We get a big output, but the main isseu:

panic: in crypto/sha256.Sum224: cannot convert slice t0[:] ([]byte) to *[28]byte

I hope that this is enough information, this is my first time opening an issue/bug. So feel free to provide me with any feedback to learn from for the next time.

Cheers

[seankhliao]

please include the go env output

[seankhliao]

Looks like gotext was installed using @latest, which is x/text@v0.3.7 and requires x/tools@v0.0.0-20180917221912-90fa682c2a6e.
CL 353350 updates it to x/tools@v0.1.7 to pick up the required updates (latest is x/tools@v0.1.10), but there hasn't been a release since

cc @mpvl @golang/release

[ALTree]

Tagging a new x/text release is possibly blocked by #47566 / #45093 (CL 304029 ) (?)

[mvdan]

The above were fixed by https://go-review.googlesource.com/c/text/+/304029, I think.

I think we're all good to do a release soon? cc @rolandshoemaker

[esote]

@mvdan @rolandshoemaker x/text has had 2 releases (v0.3.8 and v0.4.0) since the original post, I think this issue is good to close.

[ALTree]

Agree. Closing then.