Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: LookupMX behaviour broken [1.15 backport] #47012

Closed
dmitshur opened this issue Jul 1, 2021 · 4 comments
Closed

net: LookupMX behaviour broken [1.15 backport] #47012

dmitshur opened this issue Jul 1, 2021 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.15.14

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 1, 2021

This is a tracking issue for backporting a fix for #46979 to the next 1.15 minor release, since it also appears to be affected, per #34536. (It corresponds to 1.16's #46999.)

CC @FiloSottile.
@dmitshur dmitshur added release-blocker CherryPickCandidate Used during the release process for point releases labels Jul 1, 2021
@dmitshur dmitshur added this to the Go1.15.14 milestone Jul 1, 2021
@dmitshur dmitshur mentioned this issue Jul 1, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/332372 mentions this issue: [release-branch.go1.15] net: don't reject null mx records

@dmitshur dmitshur mentioned this issue Jul 1, 2021
Closed
@dmitshur
Copy link
Contributor Author

dmitshur commented Jul 1, 2021

We've considered this in a release meeting. Approving as it is a serious issue without a workaround. This backport applies to both 1.16 (#46999) and 1.15 (this issue).

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jul 1, 2021
@gopherbot
Copy link
Contributor

Closed by merging 0579cf1 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Jul 8, 2021
@rolandshoemaker
[release-branch.go1.15] net: don't reject null mx records
0579cf1 
Bypass hostname validity checking when a null mx record is returned as,
defined in RFC 7505.

Updates #46979
Updates #47012

Change-Id: Ibe683bd6b47333a8ff30909fb2680ec8e10696ef
Reviewed-on: https://go-review.googlesource.com/c/go/+/332094
Trust: Roland Shoemaker <roland@golang.org>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
(cherry picked from commit 03761ed)
Reviewed-on: https://go-review.googlesource.com/c/go/+/332372
Run-TryBot: Katie Hockman <katie@golang.org>
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/333331 mentions this issue: [release-branch.go1.15] net: filter bad names from Lookup functions instead of hard failing

gopherbot pushed a commit that referenced this issue Jul 8, 2021
@rolandshoemaker
[release-branch.go1.15] net: filter bad names from Lookup functions i…
3d1d066 
…nstead of hard failing

Instead of hard failing on a single bad record, filter the bad records
and return anything valid. This only applies to the methods which can
return multiple records, LookupMX, LookupNS, LookupSRV, and LookupAddr.

When bad results are filtered out, also return an error, indicating
that this filtering has happened.

Updates #46241
Updates #46979
Fixes #47012

Change-Id: I6493e0002beaf89f5a9795333a93605abd30d171
Reviewed-on: https://go-review.googlesource.com/c/go/+/332549
Trust: Roland Shoemaker <roland@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
(cherry picked from commit 296ddf2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/333331
Run-TryBot: Roland Shoemaker <roland@golang.org>
@golang golang locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.15.14
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot