Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/text/message/pipeline: test broken by CL 381317 #52711

Closed
bcmills opened this issue May 4, 2022 · 2 comments
Closed

x/text/message/pipeline: test broken by CL 381317 #52711

bcmills opened this issue May 4, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.19

Comments

@bcmills
Copy link
Contributor

bcmills commented May 4, 2022 •
edited
Loading 

panic: T

goroutine 753 [running]:
golang.org/x/tools/go/ssa.(*Program).needMethods(0xd457100, {0x8561fb8, 0xc6ab180}, 0x0)
	/workdir/gopath/pkg/mod/golang.org/x/tools@v0.1.10/go/ssa/methods.go:237 +0x571
golang.org/x/tools/go/ssa.(*Program).needMethods(0xd457100, {0x8561f40, 0xcce78c0}, 0x0)
	/workdir/gopath/pkg/mod/golang.org/x/tools@v0.1.10/go/ssa/methods.go:193 +0x504
golang.org/x/tools/go/ssa.(*Program).needMethods(0xd457100, {0x8561fa0, 0xb9351a0}, 0x0)
	/workdir/gopath/pkg/mod/golang.org/x/tools@v0.1.10/go/ssa/methods.go:233 +0x5ab
golang.org/x/tools/go/ssa.(*Program).needMethods(0xd457100, {0x8561f40, 0xda1a728}, 0x0)
	/workdir/gopath/pkg/mod/golang.org/x/tools@v0.1.10/go/ssa/methods.go:181 +0x186
golang.org/x/tools/go/ssa.(*Program).needMethods(0xd457100, {0x8561f28, 0xce9dbc0}, 0x0)
	/workdir/gopath/pkg/mod/golang.org/x/tools@v0.1.10/go/ssa/methods.go:215 +0x358
golang.org/x/tools/go/ssa.(*Program).needMethodsOf(0xd457100, {0x8561f28, 0xce9dbc0})
	/workdir/gopath/pkg/mod/golang.org/x/tools@v0.1.10/go/ssa/methods.go:145 +0x4b
golang.org/x/tools/go/ssa.(*Package).build(0x10b8a080)
	/workdir/gopath/pkg/mod/golang.org/x/tools@v0.1.10/go/ssa/builder.go:2284 +0xe8
sync.(*Once).doSlow(0x10b8a098, 0xb167fdc)
	/workdir/go/src/sync/once.go:70 +0xb3
sync.(*Once).Do(0x10b8a098, 0xb167fdc)
	/workdir/go/src/sync/once.go:61 +0x3f
golang.org/x/tools/go/ssa.(*Package).Build(...)
	/workdir/gopath/pkg/mod/golang.org/x/tools@v0.1.10/go/ssa/builder.go:2272
golang.org/x/tools/go/ssa.(*Program).Build.func1(0x10b8a080)
	/workdir/gopath/pkg/mod/golang.org/x/tools@v0.1.10/go/ssa/builder.go:2256 +0x54
created by golang.org/x/tools/go/ssa.(*Program).Build
	/workdir/gopath/pkg/mod/golang.org/x/tools@v0.1.10/go/ssa/builder.go:2255 +0x16c
FAIL	golang.org/x/text/message/pipeline	1.552s
@gopherbot gopherbot added this to the Unreleased milestone May 4, 2022
@bcmills bcmills changed the title x/text/message/pipeline, x/text/message/pipeline: test broken by CL 381317 May 4, 2022
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels May 4, 2022
@bcmills bcmills modified the milestones: Unreleased, Go1.19 May 4, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/403852 mentions this issue: go.mod: update x/tools to HEAD

@bcmills bcmills self-assigned this May 4, 2022
@bcmills
Copy link
Contributor Author

bcmills commented May 4, 2022

Fix is easy, so I've mailed a CL.

@bcmills bcmills mentioned this issue May 5, 2022
Closed
@rsc rsc unassigned bcmills Jun 22, 2022
xhit pushed a commit to xhit/text that referenced this issue Oct 10, 2022
@xhit
go.mod: update x/tools to HEAD
692c50b 
x/tools/go/ssa is used by message/pipeline, and at its latest release
does not support generics. However, x/tools/go/ssa does seem to
support generics at head; upgrade to fix a build break if Go 1.19
ships with generic APIs in any imported packages.

Fixes golang/go#52711.

Change-Id: I75492dbcdfef9024ec2bc324f44c01a4239e1efd
Reviewed-on: https://go-review.googlesource.com/c/text/+/403852
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.19
Development

No branches or pull requests
2 participants
@bcmills @gopherbot