Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pprof: graphviz node names are funny with generics [1.19 backport] #54420

Closed
gopherbot opened this issue Aug 12, 2022 · 3 comments
Closed
Assignees
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Aug 12, 2022

@prattmic requested issue #54105 to be considered for backport to the next 1.19 minor release.

@gopherbot Please backport to 1.19. This fix just barely missed 1.19. While it does have a workaround (use upstream pprof instead of go tool pprof), that is unlikely to be clear to users, and the fix is simple.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 12, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 12, 2022
@gopherbot gopherbot added this to the Go1.19.1 milestone Aug 12, 2022
@prattmic
Copy link
Member

prattmic commented Aug 12, 2022

Note that we are backporting an update of github.com/google/pprof. This update CL includes two pprof changes (google/pprof@d04f242 and google/pprof@a41b82a). Only the latter is needed to fix the bug, but IMO the other is safe enough that it is not worth creating a custom backport CL to avoid that commit.

@gopherbot
Copy link
Author

gopherbot commented Aug 12, 2022

Change https://go.dev/cl/423356 mentions this issue: [release-branch.go1.19] cmd: vendor github.com/google/pprof to fix mangled type parameter symbol names

@joedian joedian added the CherryPickApproved Used during the release process for point releases label Aug 17, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 17, 2022
@prattmic prattmic self-assigned this Aug 17, 2022
@gopherbot
Copy link
Author

gopherbot commented Aug 19, 2022

Closed by merging 2375ef8 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Aug 19, 2022
…ngled type parameter symbol names

Updates github.com/google/pprof to bring in the commit from
google/pprof#717 which fixes mangled
symbol names for type parameters.

For #54105
Fixes #54420

Change-Id: I01af9f780aba3338b960a03b30906a23642e4448
Reviewed-on: https://go-review.googlesource.com/c/go/+/420234
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit cd9cd92)
Reviewed-on: https://go-review.googlesource.com/c/go/+/423356
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Sep 8, 2022
…ngled type parameter symbol names

Updates github.com/google/pprof to bring in the commit from
google/pprof#717 which fixes mangled
symbol names for type parameters.

For golang#54105
Fixes golang#54420

Change-Id: I01af9f780aba3338b960a03b30906a23642e4448
Reviewed-on: https://go-review.googlesource.com/c/go/+/420234
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit cd9cd92)
Reviewed-on: https://go-review.googlesource.com/c/go/+/423356
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
Status: Done
Development

No branches or pull requests

3 participants