Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/pprof: graphviz node names are funny with generics [1.18 backport] #54464

Closed
prattmic opened this issue Aug 15, 2022 · 3 comments
Closed

cmd/pprof: graphviz node names are funny with generics [1.18 backport] #54464

prattmic opened this issue Aug 15, 2022 · 3 comments
Assignees
@prattmic
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.18.6

Comments

@prattmic
Copy link
Member

prattmic commented Aug 15, 2022 •
edited
Loading

@prattmic requested issue #54105 to be considered for backport to the next 1.18 minor release.

@gopherbot Please backport to 1.18. While it does have a workaround (use upstream pprof instead of go tool pprof), that is unlikely to be clear to users.
@prattmic prattmic added CherryPickCandidate Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. labels Aug 15, 2022
@prattmic prattmic added this to the Go1.18.6 milestone Aug 15, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/423576 mentions this issue: [release-branch.go1.18] cmd: upgrade github.com/google/pprof to v0.0.0-20220729232143-a41b82acbcb1

@prattmic
Copy link
Member Author

https://go.dev/cl/423576 is a straight update CL to the same version of pprof used in the 1.19 backport.

Unfortunately this also pulls in updates to x/sys and github.com/ianlancetaylor/demangle, not because they are strictly required, but because google/pprof#702 explicitly updated them in pprof.

cc @dmitshur

@joedian joedian added the CherryPickApproved Used during the release process for point releases label Aug 17, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 17, 2022
@prattmic prattmic self-assigned this Aug 17, 2022
@gopherbot
Copy link
Contributor

Closed by merging 27ced96 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Aug 19, 2022
@prattmic @joedian
[release-branch.go1.18] all: upgrade github.com/google/pprof to v0.0.…
27ced96 
…0-20220729232143-a41b82acbcb1

Update the vendored copy of github.com/google/pprof to include the fix
for #54105.

pprof's go.mod specifies an upgrade to x/sys, thus we must also update
std's x/sys to match this version.

For #54105.
Fixes #54464.

Change-Id: I0ca4f338b3ec3e8c54a892eb684a5dd3af8d7f1b
Reviewed-on: https://go-review.googlesource.com/c/go/+/423576
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
@golang golang locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@prattmic prattmic

Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.18.6
Development

No branches or pull requests
3 participants
@prattmic @gopherbot @joedian