x/tools/gopls: utilize placeholders in var! postfix suggestion

[caichuanwang]

Is your feature request related to a problem? Please describe.
I'm always frustrated when I use [var!] to automatically fill in a variable, the cursor is always not selected by default. I need to move the cursor to the variables one by one instead of using [tab] to quickly edit the name of the variable

Describe the solution you'd like
Directly use [tab] to quickly edit the name of the variable

Describe alternatives you've considered
no ，There is no alternative but to move the cursors one by one

Additional context
Add any other context or screenshots about the feature request here.

[hyangah]

@caichuanwang Can you please share a screenshot or an example to demonstrate the issue? That will help us understand the issue. And, please share your vscode settings.json. Thanks!

[caichuanwang]

this is my setting.json about go in vs code
"go.lintTool": "golangci-lint", "go.lintFlags": ["--fast"], "editor.fontFamily": "JetBrains Mono,FiraCode-Retina,Menlo, Monaco, 'Courier New', monospace", "editor.fontSize": 14, "go.inlayHints.constantValues": true, "better-comments.highlightPlainText": true
now is

vscode.mp4

but i want that like goland

goland.mp4

I think this is a feature,not bug

[hyangah]

Thanks for the example and screenshot, @caichuanwang
I also think that utilizing the snippet position placeholders when the suggested vars are fake is better.
Moving this to gopls issue tracker.

Related code:
https://github.com/golang/tools/blob/60d9c064d4efe2a5b76fa64ecfc012671ee8f231/gopls/internal/lsp/source/completion/postfix_snippets.go#L306-L307
https://github.com/golang/tools/blob/60d9c064d4efe2a5b76fa64ecfc012671ee8f231/gopls/internal/lsp/source/completion/postfix_snippets.go#L165-L166

[jan-xyz]

I'd like to try my luck with this! I already had a look at the code. What's the best approach? Does it make sense to migrate the postfix snippets also to snippet.Builder, or should we try to make it work with the template strings?

[gopherbot]

Change https://go.dev/cl/541277 mentions this issue: gopls/internal/lsp/source/completion: support more postfix completion for map and slice (len, for, forr)