gopls/internal/lsp/source/completion: support more postfix completion for map and slice (len, for, forr) #459

rogeryk · 2023-11-10T15:13:34Z

Add some new postfix completions (len, for, forr) for map and slice,
with additional support for chan type (for). The previous
implementation of postfix completion did not support Placeholder, which
resulted in a poor user experience. This can be seen in go.dev/issue/59689.
This commit also adds support for Placeholder and modifies some existing places
where Placeholder should have been used.

Fixes golang/go#64037
Fixes golang/go#59689

gopherbot · 2023-11-10T15:22:58Z

This PR (HEAD: 6a45dcb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-10T15:29:38Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T15:36:21Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-10T15:36:22Z

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-11T14:19:22Z

This PR (HEAD: acb9deb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-11T14:31:12Z

Message from Kun Yuan:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-11T14:31:13Z

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 3:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-16T15:37:17Z

Message from Muir Manders:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-17T14:54:35Z

Message from Robert Findley:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-17T16:02:55Z

Message from Kun Yuan:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-19T11:04:43Z

This PR (HEAD: 8801c00) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-19T11:17:29Z

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 4:

(24 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-19T11:24:23Z

This PR (HEAD: 9d08180) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-19T11:30:48Z

Message from Kun Yuan:

Patch Set 4:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-19T11:37:09Z

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 5:

(24 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T16:18:00Z

Message from Robert Findley:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T16:33:31Z

This PR (HEAD: 2c0ea0a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-20T16:48:35Z

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 6:

(24 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-20T16:55:44Z

Message from Kun Yuan:

Patch Set 6:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-22T15:39:31Z

Message from Robert Findley:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-22T15:47:07Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-22T15:30:53Z","revision":"b739499259fc90d6e9e4a5f5d8362da778883615"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-22T15:54:43Z

Message from Robert Findley:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-22T15:54:43Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-22T15:54:44Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-24T13:28:09Z

This PR (HEAD: 71fa497) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-24T13:41:38Z

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 7:

(24 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T17:49:12Z

Message from Robert Findley:

Patch Set 7: Code-Review+2 Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T17:49:13Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-29T17:30:41Z","revision":"d46ab09ddf8c0a7f2aff67d12570050a48245db9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:02:47Z

Message from Robert Findley:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:02:48Z

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-29T18:02:49Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T03:53:26Z

This PR (HEAD: bed62f8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-11-30T04:06:26Z

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 8:

(24 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T04:06:26Z

Message from Kun Yuan:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:09:38Z

Message from Robert Findley:

Patch Set 8: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:09:38Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-11-30T13:58:44Z","revision":"bf380003fdf7523cb2a1efd745d1ecff4024ec6d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:24:30Z

Message from Robert Findley:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:24:30Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:24:31Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T14:24:33Z

Message from Robert Findley:

Patch Set 8: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-11-30T16:41:57Z

Message from Dmitri Shuralyov:

Patch Set 8: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

… for map and slice (len, for, forr) Add some new postfix completions (len, for, forr) for map and slice, with additional support for chan type (for). The previous implementation of postfix completion did not support Placeholder, which resulted in a poor user experience. This can be seen in the issue golang/go#59689. This commit also adds support for Placeholder and modifies some existing places where Placeholder should have been used. Fixes golang/go#64037, golang/go#59689

gopherbot · 2023-12-01T02:36:04Z

This PR (HEAD: d61809f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/541277.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-01T02:48:47Z

Message from tricium-prod@appspot.gserviceaccount.com:

Patch Set 10:

(24 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-01T02:55:09Z

Message from Kun Yuan:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-01T03:35:00Z

Message from Robert Findley:

Patch Set 10: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-01T03:41:26Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-12-01T03:26:51Z","revision":"230350be81e1dc727bd7735da259b319aa15df9b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

… for map and slice (len, for, forr) Add some new postfix completions (len, for, forr) for map and slice, with additional support for chan type (for). The previous implementation of postfix completion did not support Placeholder, which resulted in a poor user experience. This can be seen in go.dev/issue/59689. This commit also adds support for Placeholder and modifies some existing places where Placeholder should have been used. Fixes golang/go#64037 Fixes golang/go#59689 Change-Id: I8d27e4c965ce1f8a5631dcdbe9242398fa1f8130 GitHub-Last-Rev: d61809f GitHub-Pull-Request: #459 Reviewed-on: https://go-review.googlesource.com/c/tools/+/541277 Reviewed-by: Robert Findley <rfindley@google.com> Auto-Submit: Robert Findley <rfindley@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>

gopherbot · 2023-12-01T03:47:52Z

Message from Robert Findley:

Patch Set 10: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-01T03:47:52Z

Message from Go LUCI:

Patch Set 10:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-01T03:47:53Z

Message from Go LUCI:

Patch Set 10: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/541277.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-01T03:54:33Z

This PR is being closed because golang.org/cl/541277 has been merged.

gopherbot closed this Dec 1, 2023

gopls/internal/lsp/source/completion: support more postfix completion for map and slice (len, for, forr) #459

gopls/internal/lsp/source/completion: support more postfix completion for map and slice (len, for, forr) #459

Conversation

rogeryk commented Nov 10, 2023 • edited by dmitshur Loading

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 10, 2023

gopherbot commented Nov 11, 2023

gopherbot commented Nov 11, 2023

gopherbot commented Nov 11, 2023

gopherbot commented Nov 16, 2023

gopherbot commented Nov 17, 2023

gopherbot commented Nov 17, 2023

gopherbot commented Nov 19, 2023

gopherbot commented Nov 19, 2023

gopherbot commented Nov 19, 2023

gopherbot commented Nov 19, 2023

gopherbot commented Nov 19, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 20, 2023

gopherbot commented Nov 22, 2023

gopherbot commented Nov 22, 2023

gopherbot commented Nov 22, 2023

gopherbot commented Nov 22, 2023

gopherbot commented Nov 22, 2023

gopherbot commented Nov 24, 2023

gopherbot commented Nov 24, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 29, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Nov 30, 2023

gopherbot commented Dec 1, 2023

gopherbot commented Dec 1, 2023

gopherbot commented Dec 1, 2023

gopherbot commented Dec 1, 2023

gopherbot commented Dec 1, 2023

gopherbot commented Dec 1, 2023

gopherbot commented Dec 1, 2023

gopherbot commented Dec 1, 2023

gopherbot commented Dec 1, 2023

rogeryk commented Nov 10, 2023 •

edited by dmitshur

Loading