Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/test/integration/misc: TestRenamePackage_NestedModule failures #64984

Closed
gopherbot opened this issue Jan 6, 2024 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRenamePackage_NestedModule"

Issue created automatically to collect these failures.

Example (log):

serve.go:443: debug server listening at http://localhost:49278
serve.go:443: debug server listening at http://localhost:49279
goroutine profile: total 10
2 @ 0x103cf4e 0x1036137 0x106a7a5 0x10a9387 0x10ae86c 0x10ae85a 0x1240c49 0x125537e 0x1254550 0x163bfe4 0x181b4a5 0x181b4a6 0x1070d21
#	0x106a7a4	internal/poll.runtime_pollWait+0x84					/tmp/buildlet/go/src/runtime/netpoll.go:343
#	0x10a9386	internal/poll.(*pollDesc).wait+0x26					/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:84
#	0x10ae86b	internal/poll.(*pollDesc).waitRead+0x2ab				/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:89
#	0x10ae859	internal/poll.(*FD).Accept+0x299					/tmp/buildlet/go/src/internal/poll/fd_unix.go:611
#	0x1240c48	net.(*netFD).accept+0x28						/tmp/buildlet/go/src/net/fd_unix.go:172
#	0x125537d	net.(*TCPListener).accept+0x1d						/tmp/buildlet/go/src/net/tcpsock_posix.go:152
...
1 @ 0x103cf4e 0x104d305 0x1264985 0x1070d21
#	0x1264984	golang.org/x/tools/internal/jsonrpc2.Serve+0x384	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve.go:112

1 @ 0x103cf4e 0x106d885 0x13d5b76 0x1070d21
#	0x106d884	time.Sleep+0x124					/tmp/buildlet/go/src/runtime/time.go:195
#	0x13d5b75	golang.org/x/tools/gopls/internal/filecache.gc+0x275	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/filecache/filecache.go:507

--- FAIL: TestRenamePackage_NestedModule (3.61s)
    --- FAIL: TestRenamePackage_NestedModule/default (3.61s)
        runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /tmp/buildlet/tmp/gopls-test-4165152782/TestRenamePackage_NestedModule/default: directory not empty

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 6, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRenamePackage_NestedModule"
2024-01-03 12:29 darwin-amd64-nocgo tools@a863a4fc go@f6b203c8 x/tools/gopls/internal/test/integration/misc.TestRenamePackage_NestedModule (log)
serve.go:443: debug server listening at http://localhost:49278
serve.go:443: debug server listening at http://localhost:49279
goroutine profile: total 10
2 @ 0x103cf4e 0x1036137 0x106a7a5 0x10a9387 0x10ae86c 0x10ae85a 0x1240c49 0x125537e 0x1254550 0x163bfe4 0x181b4a5 0x181b4a6 0x1070d21
#	0x106a7a4	internal/poll.runtime_pollWait+0x84					/tmp/buildlet/go/src/runtime/netpoll.go:343
#	0x10a9386	internal/poll.(*pollDesc).wait+0x26					/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:84
#	0x10ae86b	internal/poll.(*pollDesc).waitRead+0x2ab				/tmp/buildlet/go/src/internal/poll/fd_poll_runtime.go:89
#	0x10ae859	internal/poll.(*FD).Accept+0x299					/tmp/buildlet/go/src/internal/poll/fd_unix.go:611
#	0x1240c48	net.(*netFD).accept+0x28						/tmp/buildlet/go/src/net/fd_unix.go:172
#	0x125537d	net.(*TCPListener).accept+0x1d						/tmp/buildlet/go/src/net/tcpsock_posix.go:152
...
1 @ 0x103cf4e 0x104d305 0x1264985 0x1070d21
#	0x1264984	golang.org/x/tools/internal/jsonrpc2.Serve+0x384	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/jsonrpc2/serve.go:112

1 @ 0x103cf4e 0x106d885 0x13d5b76 0x1070d21
#	0x106d884	time.Sleep+0x124					/tmp/buildlet/go/src/runtime/time.go:195
#	0x13d5b75	golang.org/x/tools/gopls/internal/filecache.gc+0x275	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/filecache/filecache.go:507

--- FAIL: TestRenamePackage_NestedModule (3.61s)
    --- FAIL: TestRenamePackage_NestedModule/default (3.61s)
        runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /tmp/buildlet/tmp/gopls-test-4165152782/TestRenamePackage_NestedModule/default: directory not empty

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 6, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jan 6, 2024
@findleyr
Copy link
Contributor

findleyr commented Jan 8, 2024

Dupe of #64971.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants