-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Open
Labels
Buildersx/build issues (builders, bots, dashboards)x/build issues (builders, bots, dashboards)FeatureRequestIssues asking for a new feature that does not need a proposal.Issues asking for a new feature that does not need a proposal.NeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.new-builder
Milestone
Description
Our builders for the most part only run on Haswell CPUs on Google Compute Engine.
A number of Go packages in the standard library and runtime use assembly to choose alternate paths depending on the capabilities of the processor.
I feel like we're not getting good test coverage, only testing the Haswell paths.
We do have a GOARCH=386 builder, though, which is at one extreme, but there are a number of steps in the middle untested.
Can we put an abstraction over CPUID etc somewhere (unexported) such that the builders can fake it before assembly code can?
Metadata
Metadata
Assignees
Labels
Buildersx/build issues (builders, bots, dashboards)x/build issues (builders, bots, dashboards)FeatureRequestIssues asking for a new feature that does not need a proposal.Issues asking for a new feature that does not need a proposal.NeedsFixThe path to resolution is known, but the work has not been done.The path to resolution is known, but the work has not been done.new-builder