Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto lacks an implementation of MD4 #279

Closed
gopherbot opened this issue Nov 20, 2009 · 5 comments
Closed

Crypto lacks an implementation of MD4 #279

gopherbot opened this issue Nov 20, 2009 · 5 comments

Comments

@gopherbot
Copy link
Contributor

by calennert:

What steps will reproduce the problem?
1. Code:
package main

import (
    "fmt";
    "crypto/md4";
    "io"
)

func main() {
    h := md4.New();
    io.WriteString(h, "abc");
    fmt.Printf("%x\n", h.Sum());
}
2. Fails to compile due to lack of 'crypto/md4' package.

What is the expected output? What do you see instead?
Expected output is proper compilation with stdout output 
being 'a448017aaf21d8525fc10ae87aa6729d'.

What is your $GOOS?  $GOARCH?
GOOS=linux
GOARCH=amd64

Which revision are you using?  (hg identify)
4171:d25a47920411

Please provide any additional information below.
The attached patch provides an implementation of MD4 via a new 
package 'crypto/md4'.  The 'crypto/md5' package provided the bulk of the 
implementation details (thanks!). 

Compile (all.bash) compiles properly and all MD4 tests pass.

Note: Having MD4 in Go will facilitate working with mechanisms such as 
NLTM that make use of this hashing algorithm.

Attachments:

  1. md4.patch (8833 bytes)
@gopherbot
Copy link
Contributor Author

Comment 1 by calennert:

NTLM, rather...

@gopherbot
Copy link
Contributor Author

Comment 2 by calennert:

NTLM, rather...
Also, I omitted '\' in src/pkg/Makefile which broke the compile.  Corrected version 
attached.

Attachments:

  1. md4_corrected.patch (8834 bytes)

@rsc
Copy link
Contributor

rsc commented Nov 20, 2009

Comment 3:

Thanks for implementing this.
Could you please submit the code using the
process described at http://golang.org/doc/contribute.html?
Thanks again.

Owner changed to r...@golang.org.

Status changed to Accepted.

@gopherbot
Copy link
Contributor Author

Comment 4 by calennert:

Done.

@rsc
Copy link
Contributor

rsc commented Nov 24, 2009

Comment 5:

This issue was closed by revision 8ebd7f7.

Status changed to Fixed.

Merged into issue #-.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc removed their assignment Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants