testing: panic in Init if flag.Parse has already been called #31859
Description
What version of Go are you using (go version)?
$ go version go version devel +b41eee4 Sun May 5 15:17:52 2019 +0000 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env GOARCH="amd64" GOBIN="" GOCACHE="/Users/viacheslav.poturaev/Library/Caches/go-build" GOENV="/Users/viacheslav.poturaev/Library/Preferences/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/viacheslav.poturaev/go" GOPROXY="direct" GOROOT="/Users/viacheslav.poturaev/sdk/gotip" GOSUMDB="off" GOTMPDIR="" GOTOOLDIR="/Users/viacheslav.poturaev/sdk/gotip/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="/Users/viacheslav.poturaev/go/src/github.com/hellofresh/ro-kit/cc/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/lb/j0gz8jln36z4frqkrzmkdb0c0000gp/T/go-build279729567=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?
Ran test having custom command line flags, minimal example:
package my_test
import (
"flag"
"testing"
)
func init() {
flag.Parse()
}
func TestSomething(t *testing.T) {}What did you expect to see?
go1.12 test .
ok github.com/bla/cc 0.007s
What did you see instead?
gotip test .
flag provided but not defined: -test.testlogfile
Usage of /var/folders/lb/j0gz8jln36z4frqkrzmkdb0c0000gp/T/go-build200454244/b001/cc.test:
FAIL github.com/bla/cc 0.007s