Skip to content

cmd/pprof: update for driver.ObjTool interface change #38802

@dmitshur

Description

@dmitshur

The driver.ObjTool interface has changed in google/pprof@b1a9688 as follows:

 	// Disasm disassembles the named object file, starting at
 	// the start address and stopping at (before) the end address.
-	Disasm(file string, start, end uint64) ([]Inst, error)
+	Disasm(file string, start, end uint64, intelSyntax bool) ([]Inst, error)

In order to be able to update to a newer version of github.com/google/pprof dependency (part of #36905), we need to know how to update the objTool.Disasm method to conform to the new signature.

@hyangah, can you tell if we should use the intelSyntax value in some way, or should it be unused?

/cc @hyangah @wyk9787 @aalexand

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions