reflect: DeepEqual can return true for values that are not equal #39607
Description
What version of Go are you using (go version)?
$ go version go version go1.14.4 linux/amd64
Does this issue reproduce with the latest release?
Yes, go1.14.4. It does not happen with go1.13.12.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/home/me/.cache/go-build" GOENV="/home/me/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/me/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/lib/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build795938586=/tmp/go-build -gno-record-gcc-switches"
What did you do?
I ran https://play.golang.org/p/h2Wt6eYJB0B:
package main
import (
"fmt"
"reflect"
)
type testingStruct struct {
f1 *testingStruct
f2 string
}
func main() {
s1 := &testingStruct{
f1: &testingStruct{
f2: "foo",
},
}
s2 := &testingStruct{
f1: &testingStruct{
f2: "foobar",
},
}
fmt.Println(reflect.DeepEqual(s1, s2))
}
What did you expect to see?
I expected it to print "false".
What did you see instead?
It printed "true".