Skip to content

os/exec: TestContextCancel is flaky on netbsd-arm64-bsiegert builder #42061

@bcmills

Description

@bcmills

2020-10-18T08:22:01-515e6a9/netbsd-arm64-bsiegert
2020-10-16T03:02:36-912262b/netbsd-arm64-bsiegert
2020-10-14T15:19:28-52669c4/netbsd-arm64-bsiegert
2020-10-12T21:13:04-15a11ce/netbsd-arm64-bsiegert
2020-10-07T20:18:35-ade5161/netbsd-arm64-bsiegert
2020-10-06T22:56:00-f8e5540/netbsd-arm64-bsiegert
2020-10-06T21:55:49-2e4ceaf/netbsd-arm64-bsiegert

It looks like the test hard-codes a 1-second timeout on the cancellation terminating the child process. That might not be a reasonable assumption on slow, heavily-loaded builders.

go/src/os/exec/exec_test.go

Lines 1081 to 1083 in f8df205

if time.Since(start) > time.Second {
t.Fatal("canceling context did not stop program")
}

CC @bsiegert @bradfitz @ianlancetaylor

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions