Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: always emit a critical SAN extension if the Subject is empty in a CSR #46810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rboyer
Copy link

@rboyer rboyer commented Jun 17, 2021

When using x509.CreateCertificate empty Subject fields correctly set the
SAN extension as critical. This changeset ensures that
x509.CreateCertificateRequest does the same thing.

This was previously fixed in x509.CreateCertificate with:
https://go-review.googlesource.com/70852

…mpty in a CSR

When using x509.CreateCertificate empty Subject fields correctly set the
SAN extension as critical. This changeset ensures that
x509.CreateCertificateRequest does the same thing.

This was previously fixed in x509.CreateCertificate with:
https://go-review.googlesource.com/70852
@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Jun 17, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 8784317) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/329129 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/329129.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants