runtime: stack trace on panic does not include all parameters in 1.17 #47159
Description
What version of Go are you using (go version)?
$ go version go version go1.17beta1 linux/amd64
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/home/michael/.cache/go-build" GOENV="/home/michael/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GOMODCACHE="/home/michael/go/pkg/mod" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/michael/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/home/michael/sdk/go1.17beta1" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/home/michael/sdk/go1.17beta1/pkg/tool/linux_amd64" GOVCS="" GOVERSION="go1.17beta1" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/home/michael/go/src/github.com/maruel/panicparse/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build258492713=/tmp/go-build -gno-record-gcc-switches"
What did you do?
git clone https://github.com/maruel/panicparse
cd panicparse/cmd/panic
go run -gcflags '-N -l' main.go main_no_race.go args_elided
What did you expect to see?
1.16 output:
go run -gcflags '-N -l' main.go main_no_race.go args_elided
GOTRACEBACK=
panic: 1
goroutine 1 [running]:
main.panicArgsElided(0x1, 0x2, 0x3, 0x4, 0x5, 0x6, 0x7, 0x8, 0x9, 0xa, ...)
/root/panicparse/cmd/panic/main.go:105 +0x4f
main.glob..func1()
/root/panicparse/cmd/panic/main.go:221 +0x88
main.main()
/root/panicparse/cmd/panic/main.go:72 +0x3f9
exit status 2
What did you see instead?
GOTRACEBACK=
panic: 1
goroutine 1 [running]:
main.panicArgsElided(0x1, 0x2, 0x3, 0x4, 0x5, 0x6, 0x7, 0x8, 0x9, 0xa)
/home/michael/go/src/github.com/maruel/panicparse/cmd/panic/main.go:105 +0x5f
main.glob..func1()
/home/michael/go/src/github.com/maruel/panicparse/cmd/panic/main.go:221 +0x5b
main.main()
/home/michael/go/src/github.com/maruel/panicparse/cmd/panic/main.go:72 +0x662
exit status 2
Note that the last parameter is neither included, nor indicated as elided.
This seems like a regression compared to go 1.16.
related to maruel/panicparse#61
might be the same as #45728 but I figured I’d file a separate one just to be sure