Skip to content

cmd/internal/moddeps: TestAllDependencies fails due to bundle not working #49159

@dmitshur

Description

@dmitshur

As of CL 357049, moddeps.TestAllDependencies fails in non-short mode (as detected on the linux-amd64-longtest builder, see log) with:

--- FAIL: TestAllDependencies (9.11s)
    --- FAIL: TestAllDependencies/std(thorough) (4.62s)
        moddeps_test.go:208: > /workdir/tmp/TestAllDependencies2938390985/002/bin/go generate -run=^//go:generate bundle  std
        moddeps_test.go:208: command failed: exit status 1
            bundle: internal error: package "strings" without types was imported from "golang.org/x/net/http2"
            net/http/http.go:5: running "bundle": exit status 1
FAIL
FAIL	cmd/internal/moddeps	9.108s

TestAllDependencies builds and runs bundle, which uses golang.org/x/tools/go/packages to load packages, but starts to run into an internal error after that change.

Perhaps the x/tools version required in src/cmd/go.mod needs to be updated to include CL 358034, or maybe there's more to this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.SoonThis needs action soon. (recent regressions, service outages, unusual time-sensitive situations)

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions