Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: add check before using arguments with -buildmode=c-archive and -buildmode=c-shared on non glibc systems such as musl/uclinux #52541

Conversation

1800alex
Copy link

This PR fixes using go .so and .a libraries with non glibc systems such as musl/uclinux when linking at compile time. This fix modifies the solution found here https://go-review.googlesource.com/c/go/+/37868

This fix does not fix the issues encountered when using dlopen on musl systems, I'm opening this PR in hopes of getting some help from the go team to fix this crippling issue using musl based systems.

Previous PR here -> #47249

Tested with go 1.18 on 386/armv7/aarch64 with both libc and musl

@1800alex
Copy link
Author

Linking with #13492

@gopherbot
Copy link
Contributor

This PR (HEAD: 819d36a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/402094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/402094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: bcf7dea) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/402094 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Alex Eaton:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/402094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/402094.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/402094 has been abandoned.

As Ian mentioned above, this CL (imported from a PR) is targeting the "release-branch.go1.18" branch. Go 1.18 is no longer supported per the release policy and so we don't use the release-branch.go1.18 branch for anything now.

If this is a change you'd still like to pursue, please see https://go.dev/doc/contribute#before_contributing and send it again making sure the target branch is named master and not one of the release branches. Thanks.

@gopherbot gopherbot closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants