Skip to content

cmd/compile/internal/types2: tests include new verbose logging to stderr #56681

New issue
New issue
Closed
Closed
cmd/compile/internal/types2: tests include new verbose logging to stderr#56681
Labels
FrozenDueToAgecompiler/runtimeIssues related to the Go compiler and/or runtime.
@findleyr

Description

@findleyr
findleyr
opened on Nov 10, 2022

Following https://go.dev/cl/442303, running go test in cmd/compile/internal/types2 produces a long list of what appears to be debug output, due to a print to stderr in gcimporter.lookupGorootExport (see below). Was this left in accidentally?

In any case, I think we should probably remove this logging.

looking up  cmd/vendor/golang.org/x/tools/go/ast/astutil
looking up  cmd/vendor/golang.org/x/tools/cover
looking up  cmd/vendor/golang.org/x/mod/semver
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/modfile
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/semver
looking up  cmd/vendor/golang.org/x/mod/modfile
looking up  cmd/vendor/golang.org/x/mod/sumdb/dirhash
looking up  cmd/vendor/golang.org/x/mod/modfile
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/semver
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/semver
looking up  cmd/vendor/golang.org/x/mod/modfile
looking up  cmd/vendor/golang.org/x/mod/zip
looking up  cmd/vendor/golang.org/x/mod/sumdb/dirhash
looking up  cmd/vendor/golang.org/x/mod/sumdb
looking up  cmd/vendor/golang.org/x/mod/sumdb/note
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/semver
looking up  cmd/vendor/golang.org/x/mod/modfile
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/semver
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/semver
looking up  cmd/vendor/golang.org/x/mod/modfile
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/zip
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/modfile
looking up  cmd/vendor/golang.org/x/sync/semaphore
looking up  cmd/vendor/golang.org/x/arch/arm/armasm
looking up  cmd/vendor/golang.org/x/arch/arm64/arm64asm
looking up  cmd/vendor/golang.org/x/arch/ppc64/ppc64asm
looking up  cmd/vendor/golang.org/x/arch/x86/x86asm
looking up  cmd/vendor/golang.org/x/sys/unix
looking up  cmd/vendor/github.com/google/pprof/driver
looking up  cmd/vendor/github.com/google/pprof/profile
looking up  cmd/vendor/golang.org/x/term
looking up  cmd/vendor/github.com/google/pprof/profile
looking up  cmd/vendor/github.com/google/pprof/internal/driver
looking up  cmd/vendor/github.com/google/pprof/internal/plugin
looking up  cmd/vendor/github.com/google/pprof/profile
looking up  cmd/vendor/github.com/google/pprof/internal/plugin
looking up  cmd/vendor/github.com/google/pprof/internal/elfexec
looking up  cmd/vendor/github.com/ianlancetaylor/demangle
looking up  cmd/vendor/github.com/google/pprof/internal/binutils
looking up  cmd/vendor/github.com/google/pprof/internal/plugin
looking up  cmd/vendor/github.com/google/pprof/internal/report
looking up  cmd/vendor/github.com/google/pprof/profile
looking up  cmd/vendor/github.com/google/pprof/internal/measurement
looking up  cmd/vendor/github.com/google/pprof/internal/graph
looking up  cmd/vendor/github.com/google/pprof/internal/symbolizer
looking up  cmd/vendor/github.com/google/pprof/internal/transport
looking up  cmd/vendor/github.com/google/pprof/third_party/svgpan
looking up  cmd/vendor/github.com/google/pprof/third_party/d3flamegraph
looking up  cmd/vendor/github.com/google/pprof/internal/measurement
looking up  cmd/vendor/github.com/google/pprof/profile
looking up  cmd/vendor/github.com/google/pprof/profile
looking up  cmd/vendor/github.com/google/pprof/profile
looking up  cmd/vendor/github.com/google/pprof/internal/graph
looking up  cmd/vendor/github.com/google/pprof/internal/measurement
looking up  cmd/vendor/github.com/google/pprof/internal/plugin
looking up  cmd/vendor/github.com/google/pprof/profile
looking up  cmd/vendor/github.com/google/pprof/internal/binutils
looking up  cmd/vendor/github.com/google/pprof/internal/plugin
looking up  cmd/vendor/github.com/google/pprof/internal/symbolz
looking up  cmd/vendor/github.com/google/pprof/profile
looking up  cmd/vendor/github.com/ianlancetaylor/demangle
looking up  cmd/vendor/github.com/google/pprof/internal/plugin
looking up  cmd/vendor/github.com/google/pprof/profile
looking up  cmd/vendor/github.com/google/pprof/internal/plugin
looking up  cmd/vendor/golang.org/x/mod/internal/lazyregexp
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/semver
looking up  cmd/vendor/golang.org/x/mod/semver
looking up  cmd/vendor/golang.org/x/mod/internal/lazyregexp
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/mod/sumdb/note
looking up  cmd/vendor/golang.org/x/mod/sumdb/tlog
looking up  cmd/vendor/golang.org/x/mod/internal/lazyregexp
looking up  cmd/vendor/golang.org/x/crypto/ed25519
looking up  cmd/vendor/golang.org/x/mod/module
looking up  cmd/vendor/golang.org/x/sys/unix
looking up  cmd/vendor/golang.org/x/tools/internal/analysisinternal
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/types/objectpath
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/cfg
looking up  cmd/vendor/golang.org/x/tools/go/types/typeutil
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/types/typeutil
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/types/typeutil
looking up  cmd/vendor/golang.org/x/tools/internal/analysisinternal
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/ctrlflow
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/cfg
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/types/typeutil
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/internal/analysisinternal
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/types/typeutil
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/inspect
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil
looking up  cmd/vendor/golang.org/x/tools/go/ast/inspector
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis
looking up  cmd/vendor/golang.org/x/tools/go/analysis/internal/analysisflags
looking up  cmd/vendor/golang.org/x/tools/go/analysis/internal/facts
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/ast/astutil
looking up  cmd/vendor/golang.org/x/tools/internal/typeparams
looking up  cmd/vendor/golang.org/x/tools/go/analysis/unitchecker
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/asmdecl
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/assign
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/atomic
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/bools
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/buildtag
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/cgocall
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/composite
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/copylock
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/errorsas
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/framepointer
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/httpresponse
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/ifaceassert
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/loopclosure
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/lostcancel
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/nilfunc
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/printf
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/shift
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/sigchanyzer
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/stdmethods
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/stringintconv
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/structtag
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/testinggoroutine
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/tests
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/unmarshal
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/unreachable
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/unsafeptr
looking up  cmd/vendor/golang.org/x/tools/go/analysis/passes/unusedresult
looking up  vendor/golang.org/x/crypto/cryptobyte
looking up  vendor/golang.org/x/crypto/cryptobyte/asn1
looking up  vendor/golang.org/x/crypto/chacha20poly1305
looking up  vendor/golang.org/x/crypto/cryptobyte
looking up  vendor/golang.org/x/crypto/hkdf
looking up  vendor/golang.org/x/crypto/cryptobyte
looking up  vendor/golang.org/x/crypto/cryptobyte/asn1
looking up  vendor/golang.org/x/net/dns/dnsmessage
looking up  vendor/golang.org/x/net/http/httpguts
looking up  vendor/golang.org/x/net/http2/hpack
looking up  vendor/golang.org/x/net/idna
looking up  vendor/golang.org/x/net/http/httpproxy
looking up  vendor/golang.org/x/net/http/httpguts
looking up  vendor/golang.org/x/net/http/httpguts
looking up  vendor/golang.org/x/net/http/httpguts
looking up  vendor/golang.org/x/crypto/internal/alias
looking up  vendor/golang.org/x/crypto/internal/alias
looking up  vendor/golang.org/x/sys/cpu
looking up  vendor/golang.org/x/crypto/chacha20
looking up  vendor/golang.org/x/crypto/internal/poly1305
looking up  vendor/golang.org/x/crypto/cryptobyte/asn1
looking up  vendor/golang.org/x/net/idna
looking up  vendor/golang.org/x/net/idna
looking up  vendor/golang.org/x/text/secure/bidirule
looking up  vendor/golang.org/x/text/unicode/bidi
looking up  vendor/golang.org/x/text/unicode/norm
looking up  vendor/golang.org/x/text/transform
looking up  vendor/golang.org/x/text/unicode/bidi
looking up  vendor/golang.org/x/text/transform
PASS
ok      cmd/compile/internal/types2     5.259s

CC @matloob @bcmills @griesemer

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgecompiler/runtimeIssues related to the Go compiler and/or runtime.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions