Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd api NewWalker Reducing the code makes the code more concise #57423

Closed
wants to merge 1 commit into from
Closed

cmd api NewWalker Reducing the code makes the code more concise #57423

wants to merge 1 commit into from

Conversation

wjw1758548031
Copy link
Contributor

@wjw1758548031 wjw1758548031 commented Dec 21, 2022

cmd api NewWalker Reducing the code makes the code more concise
Fixes #54385

@gopherbot
Copy link
Contributor

This PR (HEAD: 9370645) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/458775 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/458775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from jianwen wang:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/458775.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/458775.
After addressing review feedback, remember to publish your drafts!

@wjw1758548031 wjw1758548031 changed the title cmd-api-simple-grammar cmd api NewWalker Reducing the code makes the code more concise Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

net/url: JoinPath doesn't strip relative path components in all circumstances
2 participants