-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syscall: add SysProcAttr.PseudoConsole on Windows #62710
base: master
Are you sure you want to change the base?
Conversation
86f2299
to
914b398
Compare
This PR (HEAD: 914b398) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/529315. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/529315. |
I've created a PoC here https://gist.github.com/aymanbagabas/c3e41fe211c23e2d8286f35a74162785 |
please log in and comment on gerrit, we don't really look at the github pr |
Message from Mauri de Souza Meneguzzo: Patch Set 2: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/529315. |
Message from Mauri de Souza Meneguzzo: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/529315. |
Message from Bryan Mills: Patch Set 3: Hold+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/529315. |
This allows the user to pass a ConPty handle to run a process on a ConPty session. See https://learn.microsoft.com/en-us/windows/console/creating-a-pseudoconsole-session Fixes golang#62708
914b398
to
fe2171d
Compare
This PR (HEAD: fe2171d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/529315. Important tips:
|
Message from Ayman Bagabas: Patch Set 4: (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/529315. |
Message from Mauri de Souza Meneguzzo: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/529315. |
Message from Ayman Bagabas: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/529315. |
This PR (HEAD: fe2171d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/529315. Important tips:
|
This allows the user to pass a ConPty handle to run a process on a ConPty session.
See https://learn.microsoft.com/en-us/windows/console/creating-a-pseudoconsole-session
Related creack/pty#155
Fixes #62708