-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: unexport loadImport #67091
cmd/go: unexport loadImport #67091
Conversation
This PR (HEAD: 4003b78) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581939. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from qiulaidongfeng: Patch Set 1: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-28T05:18:20Z","revision":"3f2e850ae03ffe7d394b5256f91c1c36b537aa5b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from qiulaidongfeng: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from qiulaidongfeng: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Michael Matloob: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
This PR (HEAD: 1c1a58a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581939. Important tips:
|
This PR (HEAD: 6c86e8f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581939. Important tips:
|
Message from qiulaidongfeng: Patch Set 3: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-13T22:38:30Z","revision":"6bc9ac254455d52321433cafd258cf183eafbb3b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from qiulaidongfeng: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Michael Matloob: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Dmitri Shuralyov: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Dmitri Shuralyov: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Michael Matloob: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
This PR (HEAD: f54d026) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581939. Important tips:
|
Message from qiu laidongfeng2: Patch Set 4: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-16T22:20:30Z","revision":"29778102c3d9a7e4663d7d3934d5a0ab1d92d31c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from qiu laidongfeng2: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 4: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results): FAILURE
Error:
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
f54d026
to
c664b53
Compare
This PR (HEAD: c664b53) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581939. Important tips:
|
Message from qiu laidongfeng2: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-16T22:45:40Z","revision":"87331d0241d0ac9a76a7fc58b8b47037efb6dc34"} Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from qiu laidongfeng2: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/581939. |
Complete a TODO. Change-Id: I39869df4d95a5a5f6019e281719b942fbf4ba7db GitHub-Last-Rev: c664b53 GitHub-Pull-Request: #67091 Reviewed-on: https://go-review.googlesource.com/c/go/+/581939 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This PR is being closed because golang.org/cl/581939 has been merged. |
Complete a TODO.