-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: add GoID to StackRecord produced by GoroutineProfile() #67369
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 5ca08da) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/585396. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/585396. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/585396. |
Message from Ivan Dlugoš: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/585396. |
5ca08da
to
f790446
Compare
This PR (HEAD: f790446) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/585396. Important tips:
|
f790446
to
599d78e
Compare
This PR (HEAD: 599d78e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/585396. Important tips:
|
Making this change allows mapping stack traces to goroutines across
subsequent runs of
GoroutineProfile()
. This is necessary in order touse said function as a simple continuous in-process profiler (with sample
timestamps). The other option, involving
runtime.Stack()
has worseperformance (in the runtime package) and also produces stack as a string
which then needs to be parsed back (although, at least it has the goroutine
ID)
Closes #59663