-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encoding/json: don't silently ignore errors from (*Decoder).More #67525
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: e8813ba) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586795. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-20T14:21:43Z","revision":"10690b44a394540ec026c0294068bd4556e821ce"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
This PR (HEAD: c364438) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586795. Important tips:
|
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Ian Lance Taylor: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-20T14:45:59Z","revision":"a33ccc539b5034237b3c403df6c2c4e12894d67c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
This PR (HEAD: 0000b58) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586795. Important tips:
|
0000b58
to
71ffbe9
Compare
This PR (HEAD: 71ffbe9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586795. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-20T18:18:02Z","revision":"445e1de061159585077f842b1ae0e6a43356e4b7"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
71ffbe9
to
338a31d
Compare
This PR (HEAD: 338a31d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586795. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-20T18:44:49Z","revision":"24f83d68ca2bb2b440dfb815f3824a13ba8d5f67"} Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Mateusz Poliwczak: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Joseph Tsai: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Change-Id: I56767015384d06cae6f0c4cea62a9f286bfe4743
This PR (HEAD: 1a6ff2f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/586795. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Message from Mateusz Poliwczak: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/586795. |
Currently (*Decoder).More() returns false when there is an error while
reading from the io.Reader, thus possibly hiding the error. This change
captures such errors and returns them on the next call to Decode or
Token.