-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device Flow: verification_uri vs verification_url for Google. #666
Comments
@hickford Could you please check? |
Have you reported this at developers.google.com? |
Here's a two-line fix that avoids changing the API #667 |
No, I haven't, TBH. From my previous experience it never helps with big corporations.
This works perfectly! |
This appears to be https://issuetracker.google.com/issues/151238144. |
Some servers misspell verification_uri as verification_url, contrary to spec RFC 8628 Example server https://issuetracker.google.com/issues/151238144 Fixes golang#666 Change-Id: I89e354368bbb0a4e3b979bb547b4cb37bbe1cc02 GitHub-Last-Rev: bbf169b GitHub-Pull-Request: golang#667 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/527835 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Nikolay Turpitko <nick.turpitko@gmail.com> Auto-Submit: Bryan Mills <bcmills@google.com> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Matt Hickford <matt.hickford@gmail.com>
I'm checking newly implemented Device Flow and I've found a minor issue.
Here:
Verefication URI is decoded from JSON field, named according RFC.
But here, Google uses
verification_url
name. Which is, obviously, contradicts spec, but it would be nice to be able to somehow obtain it anyway.Would it be possible to add raw data field to
DeviceAuthResponse
, or map with all received fields, or map with additional (not parsed) fields from the response JSON?The text was updated successfully, but these errors were encountered: