New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2: workaround misspelling of verification_uri #667

Closed

hickford wants to merge 1 commit into golang:master from hickford:workaround

Contributor

hickford commented Sep 12, 2023 •

edited

Loading

Some servers misspell verification_uri as verification_url, contrary to spec RFC 8628

Example server https://issuetracker.google.com/issues/151238144

Fixes #666

hickford mentioned this pull request

Device Flow: verification_uri vs verification_url for Google. #666

Closed

hickford changed the title ~~Workaround misspelling of verification_uri~~ device: workaround misspelling of verification_uri


          workaround verification_url

bbf169b

hickford force-pushed the workaround branch from b7f5d7f to bbf169b Compare

September 12, 2023 20:00

Contributor

gopherbot commented Sep 12, 2023

This PR (HEAD: bbf169b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/527835.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to register for Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

hickford changed the title ~~device: workaround misspelling of verification_uri~~ device: workaround misspelling of verification_uri

Contributor

gopherbot commented Sep 12, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 12, 2023

Message from Matt Hickford:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 12, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 12, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 12, 2023

Message from Matt Hickford:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 13, 2023

Message from Nikolay Turpitko:

Patch Set 2: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

hickford changed the title ~~device: workaround misspelling of verification_uri~~ oauth2: workaround misspelling of verification_uri

Contributor

gopherbot commented Sep 22, 2023

Message from Bryan Mills:

Patch Set 3: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 22, 2023

Message from Matt Hickford:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 22, 2023

Message from Matt Hickford:

Patch Set 4: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 22, 2023

Message from Matthew Dempsky:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 22, 2023

Message from Matt Hickford:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 22, 2023

Message from Matthew Dempsky:

Patch Set 4: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/527835.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 22, 2023

This PR is being closed because golang.org/cl/527835 has been merged.

gopherbot closed this

gopherbot pushed a commit that referenced this pull request


          oauth2: workaround misspelling of verification_uri

14b275c

Some servers misspell verification_uri as verification_url, contrary to spec RFC 8628

Example server https://issuetracker.google.com/issues/151238144

Fixes #666

Change-Id: I89e354368bbb0a4e3b979bb547b4cb37bbe1cc02
GitHub-Last-Rev: bbf169b
GitHub-Pull-Request: #667
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/527835
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Nikolay Turpitko <nick.turpitko@gmail.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Matt Hickford <matt.hickford@gmail.com>

jbrichetto pushed a commit to openly-engineering/oauth2 that referenced this pull request


          oauth2: workaround misspelling of verification_uri

07f3450

Some servers misspell verification_uri as verification_url, contrary to spec RFC 8628

Example server https://issuetracker.google.com/issues/151238144

Fixes golang#666

Change-Id: I89e354368bbb0a4e3b979bb547b4cb37bbe1cc02
GitHub-Last-Rev: bbf169b
GitHub-Pull-Request: golang#667
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/527835
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Nikolay Turpitko <nick.turpitko@gmail.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Matt Hickford <matt.hickford@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet