Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google: Make sure time is always in UTC #482

Closed
wants to merge 1 commit into from
Closed

google: Make sure time is always in UTC #482

wants to merge 1 commit into from

Conversation

ScruffyProdigy
Copy link
Contributor

If times are stored in different time zones, then we occasionally get heisenbugs about expired tokens

@google-cla google-cla bot added the cla: yes label Mar 11, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 3ff51b3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/300929 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ryan Kohler:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/300929.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tyler Bui-Palsulich:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/300929.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=428b3ae3

Please don’t reply on this GitHub thread. Visit golang.org/cl/300929.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/300929.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 11, 2021
@ScruffyProdigy @codyoss
google: Make sure time is always in UTC
5366d9d 
If times are stored in different time zones, then we occasionally get heisenbugs about expired tokens

Change-Id: I0c117977688d8d6c7b12b211092e5040a41a1f46
GitHub-Last-Rev: 3ff51b3
GitHub-Pull-Request: #482
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/300929
Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>
Trust: Tyler Bui-Palsulich <tbp@google.com>
Trust: Cody Oss <codyoss@google.com>
Run-TryBot: Tyler Bui-Palsulich <tbp@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/300929 has been merged.

@gopherbot gopherbot closed this Mar 11, 2021
@ScruffyProdigy ScruffyProdigy deleted the time branch April 18, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScruffyProdigy @gopherbot