Skip to content

google/externalaccount: validate tokenURL and ServiceAccountImpersonationURL #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 37 commits into from
Closed

google/externalaccount: validate tokenURL and ServiceAccountImpersonationURL #514

wants to merge 37 commits into from

Conversation

Galadros
Copy link
Contributor

@Galadros Galadros commented Aug 6, 2021

No description provided.

gIthuriel and others added 27 commits June 9, 2021 10:46
@gIthuriel
oauth2/google: implement support for token downscoping to allow for r…
a8e26b9 
…estricted permissions
@gIthuriel
First set of comment changes.
52684dc
@gIthuriel
Add some validity testing for AccessBoundaryRules and add documentation.
eb57311
@gIthuriel
Add exmaple showing how NewTokenSource should be called.
add9801
@gIthuriel
go fmt
e035bf9
@gIthuriel
downscope: make changes related to comments, including adding another…
69736ff 
… example and touching up comment formatting.
@gIthuriel
downscope: update comment formatting
be467ee
@gIthuriel
downscope: add some context to returned error
c4c64d5
@gIthuriel
downscope: move example files to a separate file & package
776a9ed
@gIthuriel
downscope: minor tweaks
b594a60
@gIthuriel
downscope: fixing nits and renaming
cbbc506
@gIthuriel
downscope: refactor main functionality into a method on a tokenSource…
1d9ea0c 
…, update examples accordingly, and test for maximum boundary rule violations
@gIthuriel
downscope: fix grammar and punctuation.
a362f28
@gIthuriel
downscope: further updates and nits
304d28b
@gIthuriel
downscope: refactor some code to remove an extraneous function and in…
1024258 
…stead run that code inside of Token()
@gIthuriel
downscope: change return type of NewTokenSource
1888dba
@gIthuriel
downscope: fix some nits
fec7137
@gIthuriel
downscope: move validation checks
941cf10
@gIthuriel
downscope: update documentation
c976479
@Galadros
Merge pull request #1 from Galadros/downscopeDocumentation
d921d8f 
Merging with master to fix some PR oddities for downscoping documentation
@gIthuriel
Removed some code that's not yet finished
e4ec8cd
@Galadros
Merge branch 'master' into master
3045b9f
@gIthuriel
downscope: documentation tweaks
0bd54f5
@gIthuriel
Merge branch 'master' of github.com:Galadros/oauth2
e4caaa9
@Galadros
Update example_test.go
63894e5
@Galadros
Merge branch 'golang:master' into master
387bb65
@gIthuriel
google/externalaccount: validate tokenURL and ServiceAccountImpersona…
0925f5e 
…tionURL
@google-cla google-cla bot added the cla: yes label Aug 6, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 0925f5e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/340569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Leo Siracusa:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Leo Siracusa:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Leo Siracusa:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 280ee39) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/340569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Leo Siracusa:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: a55ea9e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/340569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Leo Siracusa:

Patch Set 7:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 7:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 98cc3c1) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/340569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Leo Siracusa:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: b46ea24) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/340569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Leo Siracusa:

Patch Set 9: Code-Review+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 9: Trust+1

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e8d4c9f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/340569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: ddf4dbd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/340569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 9:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 11: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 11: Run-TryBot+1 Code-Review+1 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/340569.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 17, 2021
@gIthuriel @codyoss
google/externalaccount: validate tokenURL and ServiceAccountImpersona…
7df4dd6 
…tionURL

Change-Id: Iab70cc967fd97ac8e349a14760df0f8b02ddf074
GitHub-Last-Rev: ddf4dbd
GitHub-Pull-Request: #514
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/340569
Reviewed-by: Patrick Jones <ithuriel@google.com>
Reviewed-by: Cody Oss <codyoss@google.com>
Reviewed-by: Chris Broadfoot <cbro@golang.org>
Trust: Cody Oss <codyoss@google.com>
Run-TryBot: Cody Oss <codyoss@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/340569 has been merged.

@gopherbot gopherbot closed this Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Galadros @gopherbot @gIthuriel