-
Notifications
You must be signed in to change notification settings - Fork 2.3k
x/tools/gopls: Add note to vscode doc about tags #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As prompted [this issue](golang/go#38963) it is unclear how to setup build tags in gopls in vscode. vscode has a configuration section specific for go build tags but it is not honored by gopls which instead requires GOFLAGS environment variable to be set with the -tags flag.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This PR (HEAD: 37d1f9f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/233018 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/233018. |
As prompted [this issue](golang/go#38963) it is unclear how to setup build tags in gopls in vscode. vscode has a configuration section specific for go build tags but it is not honored by gopls which instead requires GOFLAGS environment variable to be set with the -tags flag. Change-Id: Ib74a5bca78bf222d73224590ee0344948f020f9f GitHub-Last-Rev: 37d1f9f GitHub-Pull-Request: #227 Reviewed-on: https://go-review.googlesource.com/c/tools/+/233018 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This PR is being closed because golang.org/cl/233018 has been merged. |
As prompted this issue it
is unclear how to setup build tags in gopls in vscode.
vscode has a configuration section specific for go build tags but it is
not honored by gopls which instead requires GOFLAGS environment variable
to be set with the -tags flag.