gopls: add scheme to CodeDescription.href #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

110y wants to merge 1 commit into golang:master from 110y:gopls-codedescription-href

Contributor

110y commented Feb 20, 2021

gopls

Add https scheme to CodeDescription.href

According to the LSP specification, CodeDescription.href must be URI type. As described in the RFC, the scheme is required for URI:

The scheme and path components are required, though the path may be empty (no characters).

Current gopls does not add the scheme to CodeDescription.href, and this results in some LSP clients (at least this client) which are strictly validating the URI format to be failed to populate diagnostics.


          gopls: add scheme to CodeDescription.href

6985bfe

google-cla bot added the cla: yes label

Contributor

gopherbot commented Feb 20, 2021

This PR (HEAD: 6985bfe) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/294569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Feb 20, 2021

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/294569.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 20, 2021

Message from Rebecca Stambler:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/294569.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 20, 2021

Message from Go Bot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=5e4ad265

Please don’t reply on this GitHub thread. Visit golang.org/cl/294569.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 20, 2021

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/3c9bffa1-19b6-4f8d-876b-bc555adf977f

Please don’t reply on this GitHub thread. Visit golang.org/cl/294569.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 20, 2021

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/3c9bffa1-19b6-4f8d-876b-bc555adf977f

Please don’t reply on this GitHub thread. Visit golang.org/cl/294569.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Feb 20, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/294569.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          gopls: add scheme to CodeDescription.href

0e232fa

### gopls

- Add `https` scheme to `CodeDescription.href`

According to the [LSP specification](https://microsoft.github.io/language-server-protocol/specification#diagnostic), `CodeDescription.href` must be [URI type](https://microsoft.github.io/language-server-protocol/specification#uri). As described in the [RFC](https://tools.ietf.org/html/rfc3986#section-3), the scheme is required for URI:

> The scheme and path components are required, though the path may be empty (no characters).

Current `gopls` does not add the scheme to `CodeDescription.href`, and this results in some LSP clients ([at least this client](https://github.com/autozimu/LanguageClient-neovim)) which are strictly validating the URI format to be failed to populate diagnostics.

Change-Id: I73f01c2e97ed1adb62fbed451a7c9b0c9794b66a
GitHub-Last-Rev: 6985bfe
GitHub-Pull-Request: #277
Reviewed-on: https://go-review.googlesource.com/c/tools/+/294569
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Trust: Rebecca Stambler <rstambler@golang.org>
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>

Contributor

gopherbot commented Feb 22, 2021

This PR is being closed because golang.org/cl/294569 has been merged.

gopherbot closed this

110y deleted the gopls-codedescription-href branch

February 23, 2021 11:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels