internal/lsp: skip signature help within a string literal #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

KarthikNayak wants to merge 1 commit into golang:master from KarthikNayak:fix-43397

Contributor

KarthikNayak commented Jul 25, 2021

Currently the SignatureHelp function provides signature help even when the
requested range lies within a string literal. Let's suppress this behavior and
return an error when someone requests signature help from within a string
literal.

Fixes golang/go#43397

Signed-off-by: Karthik Nayak karthik.188@gmail.com


          internal/lsp: skip signature help within a string literal

0c9549a

Currently the `SignatureHelp` function provides signature help even when the
requested range lies within a string literal. Let's suppress this behavior and
return an error when someone requests signature help from within a string
literal.

Fixes golang/go#43397

Signed-off-by: Karthik Nayak <karthik.188@gmail.com>

google-cla bot added the cla: yes label

Contributor

gopherbot commented Jul 25, 2021

This PR (HEAD: 0c9549a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/337170 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Jul 26, 2021

Message from Rebecca Stambler:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/337170.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 26, 2021

Message from Go Bot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/337170.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 26, 2021

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/tools/gopls-legacy/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/3a414858-d477-4f1f-9107-b19ee83e56ed

Please don’t reply on this GitHub thread. Visit golang.org/cl/337170.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 26, 2021

Message from Robert Findley:

Patch Set 1: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/337170.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 26, 2021

Message from kokoro:

Patch Set 1: gopls-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/3a414858-d477-4f1f-9107-b19ee83e56ed

Please don’t reply on this GitHub thread. Visit golang.org/cl/337170.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 26, 2021

Message from Peter Weinberger:

Patch Set 1: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/337170.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 26, 2021

Message from Go Bot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/337170.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          internal/lsp: skip signature help within a string literal

4fe0d6c

Currently the `SignatureHelp` function provides signature help even when the
requested range lies within a string literal. Let's suppress this behavior and
return an error when someone requests signature help from within a string
literal.

Fixes golang/go#43397

Signed-off-by: Karthik Nayak <karthik.188@gmail.com>

Change-Id: Ib03e87258622f4294bf9385bf5f0a8effe0050ee
GitHub-Last-Rev: 0c9549a
GitHub-Pull-Request: #332
Reviewed-on: https://go-review.googlesource.com/c/tools/+/337170
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Trust: Rebecca Stambler <rstambler@golang.org>
Trust: Robert Findley <rfindley@google.com>
Trust: Peter Weinberger <pjw@google.com>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>

Contributor

gopherbot commented Jul 26, 2021

This PR is being closed because golang.org/cl/337170 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels